[llvm] [KnownBits] Fix minimum denominator bounds for sdiv (PR #227264)

[via llvm-commits]

https://github.com/anandkvinu updated https://github.com/llvm/llvm-project/pull/227264

>From 7ab84dbcbbf9cfd881e0c2a9b3a22fa64079485a Mon Sep 17 00:00:00 2001
From: Anand K Vinu <20cs113anan at ug.cusat.ac.in>
Date: Tue, 29 Sep 2026 13:42:26 +0530
Subject: [PATCH 1/2] [KnownBits] Fix SDiv to set lowest unknown bit to get the
 minimum non-zero denominator

---
 llvm/lib/Support/KnownBits.cpp           |  6 +++++-
 llvm/unittests/Support/KnownBitsTest.cpp | 23 +++++++++++++++++++++++
 2 files changed, 28 insertions(+), 1 deletion(-)

diff --git a/llvm/lib/Support/KnownBits.cpp b/llvm/lib/Support/KnownBits.cpp
index 70f7a2f4fc887..81221081a4339 100644
--- a/llvm/lib/Support/KnownBits.cpp
+++ b/llvm/lib/Support/KnownBits.cpp
@@ -1255,7 +1255,11 @@ KnownBits KnownBits::sdiv(const KnownBits &LHS, const KnownBits &RHS,
     if (Exact || (-LHS.getSignedMaxValue()).uge(RHS.getSignedMaxValue())) {
       APInt Denom = RHS.getSignedMinValue();
       APInt Num = LHS.getSignedMinValue();
-      Res = Denom.isZero() ? Num : Num.sdiv(Denom);
+      // fix to set the lowest unknown bit to get the minimum non-zero
+      // denominator
+      if (Denom.isZero())
+        Denom.setBit(RHS.countMinTrailingZeros());
+      Res = Num.sdiv(Denom);
     }
   } else if (LHS.isStrictlyPositive() && RHS.isNegative()) {
     // Result is negative if Exact OR LHS u>= -RHS.
diff --git a/llvm/unittests/Support/KnownBitsTest.cpp b/llvm/unittests/Support/KnownBitsTest.cpp
index d4b8dff54f3d6..5033fc415b520 100644
--- a/llvm/unittests/Support/KnownBitsTest.cpp
+++ b/llvm/unittests/Support/KnownBitsTest.cpp
@@ -693,6 +693,29 @@ TEST(KnownBitsTest, UnaryExhaustive) {
       },
       [](const APInt &N) { return N * N; }, /*CheckOptimality=*/false);
 }
+// implementing googletest for SDIV having unknown bit in denominator.
+// To set the lowest unknown bit to get the minimum non-zero denominator.
+
+TEST(KnownBitsTest, NonZeroDenomSDiv) {
+
+  KnownBits Num(4);
+  KnownBits Denom(4);
+  // setting the masks for Ones and Zeros Num = -8.
+  Num.One.setBit(3);
+  Num.Zero.setBit(2);
+  Num.Zero.setBit(1);
+  Num.Zero.setBit(0);
+  // comment to test each edge cases. Denom = 0b0?00.
+  Denom.Zero.setBit(3);
+  // Denom.Zero.setBit(2);
+  Denom.Zero.setBit(1);
+  Denom.Zero.setBit(0);
+  KnownBits Result = KnownBits::sdiv(Num, Denom);
+  KnownBits Answer(4);
+  Answer.One.setHighBits(3);
+
+  EXPECT_EQ(Result, Answer);
+}
 
 TEST(KnownBitsTest, FunnelShiftExhaustive) {
   unsigned Bits = 4;

>From a999dc72ff4cb4382bb68036e87bc0313b6e27d6 Mon Sep 17 00:00:00 2001
From: "Anand.k.vinu" <41266843+anandkvinu at users.noreply.github.com>
Date: Tue, 29 Sep 2026 17:43:10 +0530
Subject: [PATCH 2/2] Update llvm/unittests/Support/KnownBitsTest.cpp

Co-authored-by: Matt Arsenault <arsenm2 at gmail.com>
---
 llvm/unittests/Support/KnownBitsTest.cpp | 2 --
 1 file changed, 2 deletions(-)

diff --git a/llvm/unittests/Support/KnownBitsTest.cpp b/llvm/unittests/Support/KnownBitsTest.cpp
index 5033fc415b520..0639aa9f6421b 100644
--- a/llvm/unittests/Support/KnownBitsTest.cpp
+++ b/llvm/unittests/Support/KnownBitsTest.cpp
@@ -693,8 +693,6 @@ TEST(KnownBitsTest, UnaryExhaustive) {
       },
       [](const APInt &N) { return N * N; }, /*CheckOptimality=*/false);
 }
-// implementing googletest for SDIV having unknown bit in denominator.
-// To set the lowest unknown bit to get the minimum non-zero denominator.
 
 TEST(KnownBitsTest, NonZeroDenomSDiv) {