[llvm] 724557a - X86: Fix missing ... separator between functions in mir test (#227228)

via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 29 02:50:54 PDT 2026


Author: Matt Arsenault
Date: 2026-09-29T09:50:40Z
New Revision: 724557a9bd1389446ba52d270ad31d78a6071497

URL: https://github.com/llvm/llvm-project/commit/724557a9bd1389446ba52d270ad31d78a6071497
DIFF: https://github.com/llvm/llvm-project/commit/724557a9bd1389446ba52d270ad31d78a6071497.diff

LOG: X86: Fix missing ... separator between functions in mir test (#227228)

The update_mir_test_checks output is incomplete so the later functions
here were really manually checked.

Added: 
    

Modified: 
    llvm/test/CodeGen/X86/two-address-subreg-to-reg-kill.mir

Removed: 
    


################################################################################
diff  --git a/llvm/test/CodeGen/X86/two-address-subreg-to-reg-kill.mir b/llvm/test/CodeGen/X86/two-address-subreg-to-reg-kill.mir
index dbbcff0498ded..55292a251bd26 100644
--- a/llvm/test/CodeGen/X86/two-address-subreg-to-reg-kill.mir
+++ b/llvm/test/CodeGen/X86/two-address-subreg-to-reg-kill.mir
@@ -1,7 +1,7 @@
 # NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py UTC_ARGS: --version 6
 # RUN: llc -mtriple=x86_64-unknown-linux-gnu --run-pass=livevars,twoaddressinstruction %s -o - | FileCheck %s
 
-# Positive case: IMUL32rm with %1 as a tied source should be hoisted 
+# Positive case: IMUL32rm with %1 as a tied source should be hoisted
 # before the pass, subreg_to_reg kills a 32-bit vreg (%1) and writes to
 # physical $eax, which allows IMUL32rm can use %eax.
 ---
@@ -19,15 +19,20 @@ body: |
     liveins: $rdi, $esi
 
     ; CHECK-LABEL: name: subreg_to_reg_kill_hoist
-    ; CHECK: [[COPY1:%[0-9]+]]:gr32 = COPY killed $esi
+    ; CHECK: liveins: $rdi, $esi
+    ; CHECK-NEXT: {{  $}}
+    ; CHECK-NEXT: [[COPY:%[0-9]+]]:gr64 = COPY killed $rdi
+    ; CHECK-NEXT: [[COPY1:%[0-9]+]]:gr32 = COPY killed $esi
     ; CHECK-NEXT: dead $rax = SUBREG_TO_REG [[COPY1]], %subreg.sub_32bit
-    ; CHECK: IMUL32rm
+    ; CHECK-NEXT: [[COPY2:%[0-9]+]]:gr32 = COPY killed [[COPY1]]
+    ; CHECK-NEXT: dead [[COPY2:%[0-9]+]]:gr32 = IMUL32rm [[COPY2]], killed [[COPY]], 1, $noreg, 4, $noreg, implicit-def dead $eflags :: (load (s32) from `ptr undef`)
+    ; CHECK-NEXT: RET 0
     %0:gr64 = COPY killed $rdi
     %1:gr32 = COPY killed $esi
     dead %2:gr32 = IMUL32rm %1, %0, 1, $noreg, 4, $noreg, implicit-def dead $eflags :: (load (s32) from `ptr undef`, align 4)
     dead $rax = SUBREG_TO_REG killed %1, %subreg.sub_32bit
     RET 0
-
+...
 ---
 # Negative case: subreg_to_reg with a vreg is not hoisted.
 # The pass keeps the IMUL32rm as is and MOV32rm + IMUL32rr is emitted instead.
@@ -46,15 +51,21 @@ body: |
     liveins: $rdi, $esi
 
     ; CHECK-LABEL: name: subreg_to_reg_virtual_dst_no_hoist
-    ; CHECK: MOV32rm
-    ; CHECK-NEXT: [[COPY2:%[0-9]+]]:gr32 = COPY
-    ; CHECK-NEXT: dead [[COPY2]]:gr32 = IMUL32rr [[COPY2]], %1, implicit-def dead $eflags
+    ; CHECK: liveins: $rdi, $esi
+    ; CHECK-NEXT: {{  $}}
+    ; CHECK-NEXT: [[COPY:%[0-9]+]]:gr64 = COPY killed $rdi
+    ; CHECK-NEXT: [[COPY1:%[0-9]+]]:gr32 = COPY killed $esi
+    ; CHECK-NEXT: [[MOV32rm:%[0-9]+]]:gr32 = MOV32rm killed [[COPY]], 1, $noreg, 4, $noreg :: (load (s32) from `ptr undef`)
+    ; CHECK-NEXT: [[COPY2:%[0-9]+]]:gr32 = COPY killed [[MOV32rm]]
+    ; CHECK-NEXT: dead [[COPY2:%[0-9]+]]:gr32 = IMUL32rr [[COPY2]], [[COPY1]], implicit-def dead $eflags
+    ; CHECK-NEXT: dead [[SUBREG_TO_REG:%[0-9]+]]:gr64 = SUBREG_TO_REG killed [[COPY1]], %subreg.sub_32bit
+    ; CHECK-NEXT: RET 0
     %0:gr64 = COPY killed $rdi
     %1:gr32 = COPY killed $esi
     dead %2:gr32 = IMUL32rm %1, %0, 1, $noreg, 4, $noreg, implicit-def dead $eflags :: (load (s32) from `ptr undef`, align 4)
     dead %3:gr64 = SUBREG_TO_REG killed %1, %subreg.sub_32bit
     RET 0
-
+...
 ---
 # Positive case: COPY to a physical register is hoisted above IMUL32rm.
 name: copy_kill_hoist
@@ -71,15 +82,20 @@ body: |
     liveins: $rdi, $esi
 
     ; CHECK-LABEL: name: copy_kill_hoist
-    ; CHECK: [[COPY1:%[0-9]+]]:gr32 = COPY killed $esi
+    ; CHECK: liveins: $rdi, $esi
+    ; CHECK-NEXT: {{  $}}
+    ; CHECK-NEXT: [[COPY:%[0-9]+]]:gr64 = COPY killed $rdi
+    ; CHECK-NEXT: [[COPY1:%[0-9]+]]:gr32 = COPY killed $esi
     ; CHECK-NEXT: dead $eax = COPY [[COPY1]]
-    ; CHECK: IMUL32rm
+    ; CHECK-NEXT: [[COPY2:%[0-9]+]]:gr32 = COPY killed [[COPY1]]
+    ; CHECK-NEXT: dead [[COPY2:%[0-9]+]]:gr32 = IMUL32rm [[COPY2]], killed [[COPY]], 1, $noreg, 4, $noreg, implicit-def dead $eflags :: (load (s32) from `ptr undef`)
+    ; CHECK-NEXT: RET 0
     %0:gr64 = COPY killed $rdi
     %1:gr32 = COPY killed $esi
     dead %2:gr32 = IMUL32rm %1, %0, 1, $noreg, 4, $noreg, implicit-def dead $eflags :: (load (s32) from `ptr undef`, align 4)
     dead $eax = COPY killed %1
     RET 0
-
+...
 ---
 # Negative case: COPY with a vreg destination is not hoisted.
 name: copy_virtual_dst_no_hoist
@@ -97,9 +113,15 @@ body: |
     liveins: $rdi, $esi
 
     ; CHECK-LABEL: name: copy_virtual_dst_no_hoist
-    ; CHECK: MOV32rm
-    ; CHECK-NEXT: [[COPY2:%[0-9]+]]:gr32 = COPY
-    ; CHECK-NEXT: dead [[COPY2]]:gr32 = IMUL32rr [[COPY2]], %1, implicit-def dead $eflags
+    ; CHECK: liveins: $rdi, $esi
+    ; CHECK-NEXT: {{  $}}
+    ; CHECK-NEXT: [[COPY:%[0-9]+]]:gr64 = COPY killed $rdi
+    ; CHECK-NEXT: [[COPY1:%[0-9]+]]:gr32 = COPY killed $esi
+    ; CHECK-NEXT: [[MOV32rm:%[0-9]+]]:gr32 = MOV32rm killed [[COPY]], 1, $noreg, 4, $noreg :: (load (s32) from `ptr undef`)
+    ; CHECK-NEXT: [[COPY2:%[0-9]+]]:gr32 = COPY killed [[MOV32rm]]
+    ; CHECK-NEXT: dead [[COPY2:%[0-9]+]]:gr32 = IMUL32rr [[COPY2]], [[COPY1]], implicit-def dead $eflags
+    ; CHECK-NEXT: dead [[COPY3:%[0-9]+]]:gr32 = COPY killed [[COPY1]]
+    ; CHECK-NEXT: RET 0
     %0:gr64 = COPY killed $rdi
     %1:gr32 = COPY killed $esi
     dead %2:gr32 = IMUL32rm %1, %0, 1, $noreg, 4, $noreg, implicit-def dead $eflags :: (load (s32) from `ptr undef`, align 4)


        


More information about the llvm-commits mailing list