[llvm] 9fe649a - [CAS] Close the stderr temp file of the out-of-process validator (#226844)

[via llvm-commits]

Author: Vladimir Shiryaev
Date: 2026-09-29T05:00:40Z
New Revision: 9fe649af67007493c02108b484c8b9259e3d522e

URL: https://github.com/llvm/llvm-project/commit/9fe649af67007493c02108b484c8b9259e3d522e
DIFF: https://github.com/llvm/llvm-project/commit/9fe649af67007493c02108b484c8b9259e3d522e.diff

LOG: [CAS] Close the stderr temp file of the out-of-process validator (#226844)

Added: 
    llvm/test/tools/llvm-cas/validate-if-needed.test

Modified: 
    llvm/lib/CAS/UnifiedOnDiskCache.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/CAS/UnifiedOnDiskCache.cpp b/llvm/lib/CAS/UnifiedOnDiskCache.cpp
index 3d0a8b3eba135..76e62f825c72c 100644
--- a/llvm/lib/CAS/UnifiedOnDiskCache.cpp
+++ b/llvm/lib/CAS/UnifiedOnDiskCache.cpp
@@ -214,10 +214,9 @@ static Error validateOutOfProcess(StringRef LLVMCasBinary, StringRef RootPath,
     Args.push_back("-check-hash");
 
   llvm::SmallString<128> StdErrPath;
-  int StdErrFD = -1;
-  if (std::error_code EC = sys::fs::createTemporaryFile(
-          "llvm-cas-validate-stderr", "txt", StdErrFD, StdErrPath,
-          llvm::sys::fs::OF_Text))
+  if (std::error_code EC =
+          sys::fs::createTemporaryFile("llvm-cas-validate-stderr", "txt",
+                                       StdErrPath, llvm::sys::fs::OF_Text))
     return createStringError(EC, "failed to create temporary file");
   FileRemover OutputRemover(StdErrPath.c_str());
 

diff  --git a/llvm/test/tools/llvm-cas/validate-if-needed.test b/llvm/test/tools/llvm-cas/validate-if-needed.test
new file mode 100644
index 0000000000000..2412cf15bfcc2
--- /dev/null
+++ b/llvm/test/tools/llvm-cas/validate-if-needed.test
@@ -0,0 +1,7 @@
+RUN: rm -rf %t
+RUN: mkdir %t
+
+RUN: llvm-cas --cas %t/cas --make-blob --data %S/Inputs/oneline
+
+RUN: llvm-cas --cas %t/cas --validate-if-needed --force | FileCheck %s
+CHECK: validated successfully