[llvm] [CodeGenPrepare] Reject select address combining if a new select's operand does not dominate it (PR #226968)

via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 28 05:25:46 PDT 2026


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- llvm/lib/CodeGen/CodeGenPrepare.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/CodeGen/CodeGenPrepare.cpp b/llvm/lib/CodeGen/CodeGenPrepare.cpp
index 093645dda..ad58db2bc 100644
--- a/llvm/lib/CodeGen/CodeGenPrepare.cpp
+++ b/llvm/lib/CodeGen/CodeGenPrepare.cpp
@@ -4211,9 +4211,8 @@ private:
   const std::function<const DominatorTree &()> getDTFn;
 
 public:
-  AddressingModeCombiner(
-      const DataLayout &DL, Value *OriginalValue,
-      const std::function<const DominatorTree &()> &getDTFn)
+  AddressingModeCombiner(const DataLayout &DL, Value *OriginalValue,
+                         const std::function<const DominatorTree &()> &getDTFn)
       : DL(DL), Original(OriginalValue), getDTFn(getDTFn) {}
 
   ~AddressingModeCombiner() { eraseCommonValueIfDead(); }

``````````

</details>


https://github.com/llvm/llvm-project/pull/226968


More information about the llvm-commits mailing list