[llvm] 44d86af - [GlobalISel][NFC] Restore the extended LLT flag to its saved value in tests (#224897)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 28 01:32:45 PDT 2026
Author: Kane Wang
Date: 2026-09-28T16:32:38+08:00
New Revision: 44d86afe24ce107f76141ae45f6fe44c44675bbe
URL: https://github.com/llvm/llvm-project/commit/44d86afe24ce107f76141ae45f6fe44c44675bbe
DIFF: https://github.com/llvm/llvm-project/commit/44d86afe24ce107f76141ae45f6fe44c44675bbe.diff
LOG: [GlobalISel][NFC] Restore the extended LLT flag to its saved value in tests (#224897)
AArch64GISelMITest's setUp() constructs an AArch64TargetMachine, which
unconditionally enables the process-global extended LLT flag. Ending the
ExtLLT tests with setUseExtended(false) therefore disables the flag for
every test that runs afterwards in the same process.
Save the flag's value on entry and restore it on exit instead.
Added:
Modified:
llvm/unittests/CodeGen/GlobalISel/LegalizerHelperTest.cpp
Removed:
################################################################################
diff --git a/llvm/unittests/CodeGen/GlobalISel/LegalizerHelperTest.cpp b/llvm/unittests/CodeGen/GlobalISel/LegalizerHelperTest.cpp
index a182054be2ca3..c543b8b90dbe1 100644
--- a/llvm/unittests/CodeGen/GlobalISel/LegalizerHelperTest.cpp
+++ b/llvm/unittests/CodeGen/GlobalISel/LegalizerHelperTest.cpp
@@ -4456,6 +4456,7 @@ TEST_F(AArch64GISelMITest, LowerIntrinsicRoundExtLLT) {
if (!TM)
GTEST_SKIP();
+ const bool SavedUseExtended = LLT::getUseExtended();
LLT::setUseExtended(true);
DefineLegalizerInfo(A, {});
@@ -4469,7 +4470,7 @@ TEST_F(AArch64GISelMITest, LowerIntrinsicRoundExtLLT) {
EXPECT_EQ(LegalizerHelper::LegalizeResult::Legalized,
Helper.lower(*Round, 0, LLT()));
- LLT::setUseExtended(false);
+ LLT::setUseExtended(SavedUseExtended);
}
// Test that lowerFFloor with extended LLT float types doesn't crash
@@ -4479,6 +4480,7 @@ TEST_F(AArch64GISelMITest, LowerFFloorExtLLT) {
if (!TM)
GTEST_SKIP();
+ const bool SavedUseExtended = LLT::getUseExtended();
LLT::setUseExtended(true);
DefineLegalizerInfo(A, {});
@@ -4492,7 +4494,7 @@ TEST_F(AArch64GISelMITest, LowerFFloorExtLLT) {
EXPECT_EQ(LegalizerHelper::LegalizeResult::Legalized,
Helper.lower(*Floor, 0, LLT()));
- LLT::setUseExtended(false);
+ LLT::setUseExtended(SavedUseExtended);
}
// Test that lowerFMODF with extended LLT float types doesn't crash
@@ -4502,6 +4504,7 @@ TEST_F(AArch64GISelMITest, LowerFMODFExtLLT) {
if (!TM)
GTEST_SKIP();
+ const bool SavedUseExtended = LLT::getUseExtended();
LLT::setUseExtended(true);
DefineLegalizerInfo(A, {});
@@ -4515,7 +4518,7 @@ TEST_F(AArch64GISelMITest, LowerFMODFExtLLT) {
EXPECT_EQ(LegalizerHelper::LegalizeResult::Legalized,
Helper.lower(*FMODF, 0, LLT()));
- LLT::setUseExtended(false);
+ LLT::setUseExtended(SavedUseExtended);
}
// Test that lowerFMinimumMaximum with extended LLT float types doesn't crash
@@ -4525,6 +4528,7 @@ TEST_F(AArch64GISelMITest, LowerFMinimumExtLLT) {
if (!TM)
GTEST_SKIP();
+ const bool SavedUseExtended = LLT::getUseExtended();
LLT::setUseExtended(true);
DefineLegalizerInfo(A, {});
@@ -4540,7 +4544,7 @@ TEST_F(AArch64GISelMITest, LowerFMinimumExtLLT) {
EXPECT_EQ(LegalizerHelper::LegalizeResult::Legalized,
Helper.lower(*FMin, 0, LLT()));
- LLT::setUseExtended(false);
+ LLT::setUseExtended(SavedUseExtended);
}
// Check that narrowScalarFPTOI only narrows conversions from IEEE half:
More information about the llvm-commits
mailing list