[compiler-rt] [sanitizer] Always report invalid aligned operator new requests (PR #225847)

[Justin T. Gibbs via llvm-commits]

================
@@ -0,0 +1,50 @@
+// Invalid alignment is a caller error, not a failure to obtain storage. ASan
+// must report it, even with allocator_may_return_null=1, rather than return
+// nullptr or call std::new_handler.
+
+// RUN: %clangxx_asan -O0 -std=c++17 %s -o %t
+// RUN: %env_asan_opts=allocator_may_return_null=1 not %run %t new 3 2>&1 | FileCheck %s
+// RUN: %env_asan_opts=allocator_may_return_null=1 not %run %t new-array 3 2>&1 | FileCheck %s
+// RUN: %env_asan_opts=allocator_may_return_null=1 not %run %t new-nothrow 3 2>&1 | FileCheck %s
+// RUN: %env_asan_opts=allocator_may_return_null=1 not %run %t new-array-nothrow 3 2>&1 | FileCheck %s
+
+// ASan does not override aligned operator new on Darwin or Windows (MSVC).
+// UNSUPPORTED: darwin, target={{.*windows-msvc.*}}
+// REQUIRES: stable-runtime
+
+#include <cassert>
+#include <cstdio>
+#include <cstdlib>
+#include <cstring>
+#include <new>
+
+static void NewHandler() {
+  std::fputs("new_handler called\n", stderr);
+  std::abort();
+}
+
+int main(int argc, char **argv) {
+  assert(argc == 3);
+  std::set_new_handler(NewHandler);
+  const auto alignment =
+      static_cast<std::align_val_t>(std::strtoull(argv[2], nullptr, 0));
+
+  void *p;
+  if (std::strcmp(argv[1], "new") == 0)
+    p = ::operator new(16, alignment);
+  else if (std::strcmp(argv[1], "new-array") == 0)
----------------
scsiguy wrote:

Now covered in the tests.

https://github.com/llvm/llvm-project/pull/225847