[llvm] [MISched](NFC) Factor control dependency construction state and logic out of `buildSchedGraph` (PR #226533)

[Tomer Shafir via llvm-commits]

================
@@ -673,70 +672,43 @@ class ScheduleDAGInstrs::Value2SUsMap
     return TrueMemOrderLatency;
   }
 
-  void dump();
-};
-
-void ScheduleDAGInstrs::addChainDependencies(SUnit *SU,
-                                             Value2SUsMap &Val2SUsMap) {
-  for (auto &I : Val2SUsMap)
-    addChainDependencies(SU, I.second,
-                         Val2SUsMap.getTrueMemOrderLatency());
-}
-
-void ScheduleDAGInstrs::addChainDependencies(SUnit *SU,
-                                             Value2SUsMap &Val2SUsMap,
-                                             ValueType V) {
-  Value2SUsMap::iterator Itr = Val2SUsMap.find(V);
-  if (Itr != Val2SUsMap.end())
-    addChainDependencies(SU, Itr->second,
-                         Val2SUsMap.getTrueMemOrderLatency());
-}
-
-void ScheduleDAGInstrs::addBarrierChain(Value2SUsMap &map) {
-  assert(BarrierChain != nullptr);
+  void dump() {
----------------
tomershafir wrote:

Why inlined? its not that small and not in a header, may be better to keep the member definition outside the class definition

https://github.com/llvm/llvm-project/pull/226533