[llvm] [AVR][NFC] Improve some comment messages (PR #226423)

[LLVM Continuous Integration via llvm-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux` running on `sanitizer-buildbot2` while building `llvm` at step 2 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/66/builds/37773

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 2 (annotate) failure: 'python ../sanitizer_buildbot/sanitizers/zorg/buildbot/builders/sanitizers/buildbot_selector.py' (failure)
...
[1939/6099] Building RISCVGenRegisterInfo.inc...
[1940/6099] Building X86GenRegisterInfo.inc...
[1941/6099] Building X86GenRegisterBank.inc...
[1942/6099] Building X86GenSDNodeInfo.inc...
[1943/6099] Building RISCVGenSearchableTables.inc...
[1944/6099] Building X86GenAsmMatcher.inc...
[1945/6099] Building X86GenFastISel.inc...
[1946/6099] Building RISCVGenSubtargetInfo.inc...
[1947/6099] Building X86GenDAGISel.inc...
[1948/6099] Building CXX object tools/clang/lib/Interpreter/CMakeFiles/obj.clangInterpreter.dir/DeviceOffload.cpp.o
FAILED: [code=1] tools/clang/lib/Interpreter/CMakeFiles/obj.clangInterpreter.dir/DeviceOffload.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes CCACHE_SLOPPINESS=pch_defines,time_macros /usr/bin/ccache /home/b/sanitizer-x86_64-linux/build/llvm_build0/bin/clang++ -DCLANG_EXPORTS -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/b/sanitizer-x86_64-linux/build/build_default/tools/clang/lib/Interpreter -I/home/b/sanitizer-x86_64-linux/build/llvm-project/clang/lib/Interpreter -I/home/b/sanitizer-x86_64-linux/build/llvm-project/clang/include -I/home/b/sanitizer-x86_64-linux/build/build_default/tools/clang/include -I/home/b/sanitizer-x86_64-linux/build/build_default/include -I/home/b/sanitizer-x86_64-linux/build/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Wno-nested-anon-types -O3 -DNDEBUG -std=c++17 -UNDEBUG -fno-exceptions -funwind-tables -fno-rtti -MD -MT tools/clang/lib/Interpreter/CMakeFiles/obj.clangInterpreter.dir/DeviceOffload.cpp.o -MF tools/clang/lib/Interpreter/CMakeFiles/obj.clangInterpreter.dir/DeviceOffload.cpp.o.d -o tools/clang/lib/Interpreter/CMakeFiles/obj.clangInterpreter.dir/DeviceOffload.cpp.o -c /home/b/sanitizer-x86_64-linux/build/llvm-project/clang/lib/Interpreter/DeviceOffload.cpp
In file included from /home/b/sanitizer-x86_64-linux/build/llvm-project/clang/lib/Interpreter/DeviceOffload.cpp:35:
/home/b/sanitizer-x86_64-linux/build/llvm-project/llvm/include/llvm/TargetParser/AMDGPUTargetParser.h:43:10: fatal error: 'llvm/TargetParser/AMDGPUTargetParserDef.inc' file not found
   43 | #include "llvm/TargetParser/AMDGPUTargetParserDef.inc"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
[1949/6099] Building AMDGPUGenSDNodeInfo.inc...
[1950/6099] Building AMDGPUGenMCPseudoLowering.inc...
[1951/6099] Building AMDGPUGenMCCodeEmitter.inc...
[1952/6099] Building RISCVGenInstrInfo.inc...
[1953/6099] Building AMDGPUGenSubtargetInfo.inc...
[1954/6099] Building X86GenGlobalISel.inc...
[1955/6099] Building AMDGPUTargetParserDef.inc...
[1956/6099] Building AMDGPUGenDisassemblerTables.inc...
[1957/6099] Building AMDGPUGenPostLegalizeGICombiner.inc...
[1958/6099] Building AMDGPUGenRegBankGICombiner.inc...
[1959/6099] Building X86GenSubtargetInfo.inc...
[1960/6099] Building AMDGPUGenSearchableTables.inc...
[1961/6099] Building X86GenInstrInfo.inc...
[1962/6099] Building RISCVGenDAGISel.inc...
[1963/6099] Building AMDGPUGenPreLegalizeGICombiner.inc...
[1964/6099] Building RISCVGenGlobalISel.inc...
[1965/6099] Building AArch64GenInstrInfo.inc...
[1966/6099] Building AArch64GenSubtargetInfo.inc...
[1967/6099] Building AMDGPUGenCallingConv.inc...
[1968/6099] Building AMDGPUGenAsmWriter.inc...
[1969/6099] Building AMDGPUGenRegisterBank.inc...
[1970/6099] Building AMDGPUGenDAGISel.inc...
[1971/6099] Building AMDGPUGenAsmMatcher.inc...
[1972/6099] Building AMDGPUGenRegisterInfo.inc...
[1973/6099] Building AMDGPUGenGlobalISel.inc...
[1974/6099] Building AMDGPUGenInstrInfo.inc...
ninja: build stopped: subcommand failed.

How to reproduce locally: https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild


@@@STEP_FAILURE@@@
Step 8 (build compiler-rt symbolizer) failure: build compiler-rt symbolizer (failure)
...
[1939/6099] Building RISCVGenRegisterInfo.inc...
[1940/6099] Building X86GenRegisterInfo.inc...
[1941/6099] Building X86GenRegisterBank.inc...
[1942/6099] Building X86GenSDNodeInfo.inc...
[1943/6099] Building RISCVGenSearchableTables.inc...
[1944/6099] Building X86GenAsmMatcher.inc...
[1945/6099] Building X86GenFastISel.inc...
[1946/6099] Building RISCVGenSubtargetInfo.inc...
[1947/6099] Building X86GenDAGISel.inc...
[1948/6099] Building CXX object tools/clang/lib/Interpreter/CMakeFiles/obj.clangInterpreter.dir/DeviceOffload.cpp.o
FAILED: [code=1] tools/clang/lib/Interpreter/CMakeFiles/obj.clangInterpreter.dir/DeviceOffload.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes CCACHE_SLOPPINESS=pch_defines,time_macros /usr/bin/ccache /home/b/sanitizer-x86_64-linux/build/llvm_build0/bin/clang++ -DCLANG_EXPORTS -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/b/sanitizer-x86_64-linux/build/build_default/tools/clang/lib/Interpreter -I/home/b/sanitizer-x86_64-linux/build/llvm-project/clang/lib/Interpreter -I/home/b/sanitizer-x86_64-linux/build/llvm-project/clang/include -I/home/b/sanitizer-x86_64-linux/build/build_default/tools/clang/include -I/home/b/sanitizer-x86_64-linux/build/build_default/include -I/home/b/sanitizer-x86_64-linux/build/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Wno-nested-anon-types -O3 -DNDEBUG -std=c++17 -UNDEBUG -fno-exceptions -funwind-tables -fno-rtti -MD -MT tools/clang/lib/Interpreter/CMakeFiles/obj.clangInterpreter.dir/DeviceOffload.cpp.o -MF tools/clang/lib/Interpreter/CMakeFiles/obj.clangInterpreter.dir/DeviceOffload.cpp.o.d -o tools/clang/lib/Interpreter/CMakeFiles/obj.clangInterpreter.dir/DeviceOffload.cpp.o -c /home/b/sanitizer-x86_64-linux/build/llvm-project/clang/lib/Interpreter/DeviceOffload.cpp
In file included from /home/b/sanitizer-x86_64-linux/build/llvm-project/clang/lib/Interpreter/DeviceOffload.cpp:35:
/home/b/sanitizer-x86_64-linux/build/llvm-project/llvm/include/llvm/TargetParser/AMDGPUTargetParser.h:43:10: fatal error: 'llvm/TargetParser/AMDGPUTargetParserDef.inc' file not found
   43 | #include "llvm/TargetParser/AMDGPUTargetParserDef.inc"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
[1949/6099] Building AMDGPUGenSDNodeInfo.inc...
[1950/6099] Building AMDGPUGenMCPseudoLowering.inc...
[1951/6099] Building AMDGPUGenMCCodeEmitter.inc...
[1952/6099] Building RISCVGenInstrInfo.inc...
[1953/6099] Building AMDGPUGenSubtargetInfo.inc...
[1954/6099] Building X86GenGlobalISel.inc...
[1955/6099] Building AMDGPUTargetParserDef.inc...
[1956/6099] Building AMDGPUGenDisassemblerTables.inc...
[1957/6099] Building AMDGPUGenPostLegalizeGICombiner.inc...
[1958/6099] Building AMDGPUGenRegBankGICombiner.inc...
[1959/6099] Building X86GenSubtargetInfo.inc...
[1960/6099] Building AMDGPUGenSearchableTables.inc...
[1961/6099] Building X86GenInstrInfo.inc...
[1962/6099] Building RISCVGenDAGISel.inc...
[1963/6099] Building AMDGPUGenPreLegalizeGICombiner.inc...
[1964/6099] Building RISCVGenGlobalISel.inc...
[1965/6099] Building AArch64GenInstrInfo.inc...
[1966/6099] Building AArch64GenSubtargetInfo.inc...
[1967/6099] Building AMDGPUGenCallingConv.inc...
[1968/6099] Building AMDGPUGenAsmWriter.inc...
[1969/6099] Building AMDGPUGenRegisterBank.inc...
[1970/6099] Building AMDGPUGenDAGISel.inc...
[1971/6099] Building AMDGPUGenAsmMatcher.inc...
[1972/6099] Building AMDGPUGenRegisterInfo.inc...
[1973/6099] Building AMDGPUGenGlobalISel.inc...
[1974/6099] Building AMDGPUGenInstrInfo.inc...
ninja: build stopped: subcommand failed.

How to reproduce locally: https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild



Step 9 (test compiler-rt symbolizer) failure: test compiler-rt symbolizer (failure)
...
+ sort -u
+ cut -f 1,2 -d ' '
+ grep -Ev '^#|^$' /home/b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/lib/sanitizer_common/symbolizer/scripts/global_symbols.txt
+ sort -u
+ grep -E '^\+[^+]'
+ diff -u expected.new undefined.new
+ cp -f symbolizer.o /home/b/sanitizer-x86_64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/lib/sanitizer_common/symbolizer/RTSanitizerCommonSymbolizerInternal.x86_64.o
+ echo 'Success!'
Success!
[2978/3347] Generating Nsan-x86_64-Test
FAILED: [code=1] compiler-rt/lib/nsan/tests/Nsan-x86_64-Test /home/b/sanitizer-x86_64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/lib/nsan/tests/Nsan-x86_64-Test 
cd /home/b/sanitizer-x86_64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/lib/nsan/tests && /home/b/sanitizer-x86_64-linux/build/build_default/./bin/clang++ NsanTestObjects.NSanUnitTest.cpp.x86_64.o NsanTestObjects.nsan_unit_test_main.cpp.x86_64.o NsanTestObjects.gtest-all.cc.x86_64.o -o /home/b/sanitizer-x86_64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/lib/nsan/tests/./Nsan-x86_64-Test -fuse-ld=lld -Wl,--color-diagnostics -Wthread-safety -Wthread-safety-reference -Wthread-safety-beta -resource-dir=/home/b/sanitizer-x86_64-linux/build/build_default/./lib/../lib/clang/24 -lstdc++ -fsanitize=numerical -m64
ld.lld: error: cannot open /home/b/sanitizer-x86_64-linux/build/build_default/./lib/../lib/clang/24/lib/x86_64-unknown-linux-gnu/libclang_rt.nsan.a: No such file or directory
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.
FAILED: [code=1] runtimes/CMakeFiles/check-compiler-rt /home/b/sanitizer-x86_64-linux/build/build_default/runtimes/CMakeFiles/check-compiler-rt 
cd /home/b/sanitizer-x86_64-linux/build/build_default/runtimes/runtimes-bins && /usr/bin/cmake --build /home/b/sanitizer-x86_64-linux/build/build_default/runtimes/runtimes-bins/ --target check-compiler-rt --config Release
ninja: build stopped: subcommand failed.

How to reproduce locally: https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild




Step 10 (build compiler-rt debug) failure: build compiler-rt debug (failure)
...
[1940/6099] Building RISCVGenRegisterInfo.inc...
[1941/6099] Building RISCVGenAsmWriter.inc...
[1942/6099] Building X86GenRegisterBank.inc...
[1943/6099] Building X86GenPreLegalizeGICombiner.inc...
[1944/6099] Building X86GenFastISel.inc...
[1945/6099] Building RISCVGenSearchableTables.inc...
[1946/6099] Building X86GenDAGISel.inc...
[1947/6099] Building RISCVGenSubtargetInfo.inc...
[1948/6099] Building AMDGPUGenMCPseudoLowering.inc...
[1949/6099] Building CXX object tools/clang/lib/Interpreter/CMakeFiles/obj.clangInterpreter.dir/DeviceOffload.cpp.o
FAILED: [code=1] tools/clang/lib/Interpreter/CMakeFiles/obj.clangInterpreter.dir/DeviceOffload.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes CCACHE_SLOPPINESS=pch_defines,time_macros /usr/bin/ccache /home/b/sanitizer-x86_64-linux/build/llvm_build0/bin/clang++ -DCLANG_EXPORTS -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/b/sanitizer-x86_64-linux/build/build_default/tools/clang/lib/Interpreter -I/home/b/sanitizer-x86_64-linux/build/llvm-project/clang/lib/Interpreter -I/home/b/sanitizer-x86_64-linux/build/llvm-project/clang/include -I/home/b/sanitizer-x86_64-linux/build/build_default/tools/clang/include -I/home/b/sanitizer-x86_64-linux/build/build_default/include -I/home/b/sanitizer-x86_64-linux/build/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Wno-nested-anon-types -O3 -DNDEBUG -std=c++17 -UNDEBUG -fno-exceptions -funwind-tables -fno-rtti -MD -MT tools/clang/lib/Interpreter/CMakeFiles/obj.clangInterpreter.dir/DeviceOffload.cpp.o -MF tools/clang/lib/Interpreter/CMakeFiles/obj.clangInterpreter.dir/DeviceOffload.cpp.o.d -o tools/clang/lib/Interpreter/CMakeFiles/obj.clangInterpreter.dir/DeviceOffload.cpp.o -c /home/b/sanitizer-x86_64-linux/build/llvm-project/clang/lib/Interpreter/DeviceOffload.cpp
In file included from /home/b/sanitizer-x86_64-linux/build/llvm-project/clang/lib/Interpreter/DeviceOffload.cpp:35:
/home/b/sanitizer-x86_64-linux/build/llvm-project/llvm/include/llvm/TargetParser/AMDGPUTargetParser.h:43:10: fatal error: 'llvm/TargetParser/AMDGPUTargetParserDef.inc' file not found
   43 | #include "llvm/TargetParser/AMDGPUTargetParserDef.inc"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
[1950/6099] Building AMDGPUTargetParserDef.inc...
[1951/6099] Building AMDGPUGenPreLegalizeGICombiner.inc...
[1952/6099] Building X86GenGlobalISel.inc...
[1953/6099] Building AMDGPUGenSubtargetInfo.inc...
[1954/6099] Building AMDGPUGenDisassemblerTables.inc...
[1955/6099] Building RISCVGenInstrInfo.inc...
[1956/6099] Building AMDGPUGenPostLegalizeGICombiner.inc...
[1957/6099] Building AMDGPUGenMCCodeEmitter.inc...
[1958/6099] Building AMDGPUGenSDNodeInfo.inc...
[1959/6099] Building RISCVGenGlobalISel.inc...
[1960/6099] Building AMDGPUGenRegBankGICombiner.inc...
[1961/6099] Building X86GenInstrInfo.inc...
[1962/6099] Building AMDGPUGenSearchableTables.inc...
[1963/6099] Building RISCVGenDAGISel.inc...
[1964/6099] Building X86GenSubtargetInfo.inc...
[1965/6099] Building AArch64GenSubtargetInfo.inc...
[1966/6099] Building AArch64GenInstrInfo.inc...
[1967/6099] Building AMDGPUGenAsmWriter.inc...
[1968/6099] Building AMDGPUGenCallingConv.inc...
[1969/6099] Building AMDGPUGenRegisterInfo.inc...
[1970/6099] Building AMDGPUGenDAGISel.inc...
[1971/6099] Building AMDGPUGenRegisterBank.inc...
[1972/6099] Building AMDGPUGenAsmMatcher.inc...
[1973/6099] Building AMDGPUGenGlobalISel.inc...
[1974/6099] Building AMDGPUGenInstrInfo.inc...
ninja: build stopped: subcommand failed.

How to reproduce locally: https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild





```

</details>

https://github.com/llvm/llvm-project/pull/226423