[llvm] [debuginfo] Add DW_AT_type support to DW_TAG_string_type DIEs (1 of 3) (PR #217419)

[Jeremy Morse via llvm-commits]

================
@@ -1666,13 +1666,16 @@ Error MetadataLoader::MetadataLoaderImpl::parseOneMetadata(
     unsigned Offset = SizeIs8 ? 5 : 6;
     Metadata *SizeInBits =
         getMetadataOrConstant(SizeIsMetadata, Record[Offset]);
+    Metadata *CharType = (Record.size() > Offset + 3)
----------------
jmorse wrote:

Offset is based on `Record.size()` anyway, yes? Better IMHO to explicitly list the permitted sizes, then it's very clear to future readers what's going on.

https://github.com/llvm/llvm-project/pull/217419