[clang] [llvm] [TargetParser][ARM][NFC] Make string tables reloc-free (PR #206937)
Tomas Matheson via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 25 05:26:43 PDT 2026
================
@@ -927,7 +927,8 @@ void tools::getTargetFeatures(const Driver &D, const llvm::Triple &Triple,
for (auto Feature : unifyTargetFeatures(Features)) {
CmdArgs.push_back(IsAux ? "-aux-target-feature" : "-target-feature");
- CmdArgs.push_back(Feature.data());
+ // Feature strings may not be null-terminated.
----------------
tommat01 wrote:
I would not expect non-null-terminated strings here, I think it makes the interface less safe/more susceptible to user errors.
https://github.com/llvm/llvm-project/pull/206937
More information about the llvm-commits
mailing list