[llvm] [SystemZ] Fix zero length PR section for zero size BSS globals (PR #225863)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 24 08:47:26 PDT 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,h -- llvm/include/llvm/MC/MCSectionGOFF.h llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp b/llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
index f3a80acdb..d1901686c 100644
--- a/llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
+++ b/llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
@@ -2938,7 +2938,8 @@ MCSection *TargetLoweringObjectFileGOFF::SelectSectionForGlobal(
// The binder rejects zero-length PR sections. If the global has zero size
// mark the PR so the writer inflates it to a valid length.
if (const auto *V = dyn_cast<GlobalVariable>(GO))
- if (GO->getParent()->getDataLayout().getTypeAllocSize(V->getValueType()) == 0)
+ if (GO->getParent()->getDataLayout().getTypeAllocSize(
+ V->getValueType()) == 0)
PR->setRequiresNonZeroLength();
return PR;
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/225863
More information about the llvm-commits
mailing list