[llvm] f5d74f5 - [AMDGPU] Remove unneeded usesCustomInserter on some opcodes. NFC. (#226055)

via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 24 01:41:40 PDT 2026


Author: Jay Foad
Date: 2026-09-24T08:41:34Z
New Revision: f5d74f58b7b2449b4ef79145670f309607b803b8

URL: https://github.com/llvm/llvm-project/commit/f5d74f58b7b2449b4ef79145670f309607b803b8
DIFF: https://github.com/llvm/llvm-project/commit/f5d74f58b7b2449b4ef79145670f309607b803b8.diff

LOG: [AMDGPU] Remove unneeded usesCustomInserter on some opcodes. NFC. (#226055)

Added: 
    

Modified: 
    llvm/lib/Target/AMDGPU/SIISelLowering.cpp
    llvm/lib/Target/AMDGPU/VOP2Instructions.td

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/AMDGPU/SIISelLowering.cpp b/llvm/lib/Target/AMDGPU/SIISelLowering.cpp
index e47dd0e788796..9b93d48235126 100644
--- a/llvm/lib/Target/AMDGPU/SIISelLowering.cpp
+++ b/llvm/lib/Target/AMDGPU/SIISelLowering.cpp
@@ -7322,11 +7322,6 @@ SITargetLowering::EmitInstrWithCustomInserter(MachineInstr &MI,
     MI.eraseFromParent();
     return BB;
   }
-  case AMDGPU::V_ADD_CO_U32_e32:
-  case AMDGPU::V_SUB_CO_U32_e32:
-  case AMDGPU::V_SUBREV_CO_U32_e32:
-    // TODO: Remove usesCustomInserter from these instructions.
-    return BB;
   case AMDGPU::V_ADDC_U32_e32:
   case AMDGPU::V_SUBB_U32_e32:
   case AMDGPU::V_SUBBREV_U32_e32:

diff  --git a/llvm/lib/Target/AMDGPU/VOP2Instructions.td b/llvm/lib/Target/AMDGPU/VOP2Instructions.td
index cab46c5efd5b3..8e0b23ca2de50 100644
--- a/llvm/lib/Target/AMDGPU/VOP2Instructions.td
+++ b/llvm/lib/Target/AMDGPU/VOP2Instructions.td
@@ -283,7 +283,7 @@ multiclass VOP2bInst <string opName,
       let Uses = !if(useSGPRInput, [VCC, EXEC], [EXEC]), Defs = [VCC] in {
         def _e32 : VOP2_Pseudo <opName, P, VOPPatOrNull<node,P>.ret>,
                    Commutable_REV<revOp#"_e32", !eq(revOp, opName)> {
-          let usesCustomInserter = true;
+          let usesCustomInserter = useSGPRInput;
         }
 
         if P.HasExtSDWA then


        


More information about the llvm-commits mailing list