[llvm] [AMDGPU] Remove unneeded usesCustomInserter on some opcodes. NFC. (PR #226055)
Jay Foad via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 24 00:55:53 PDT 2026
https://github.com/jayfoad created https://github.com/llvm/llvm-project/pull/226055
None
>From 1d02004d1f28711cfb07802ee0c03f0238fd673e Mon Sep 17 00:00:00 2001
From: Jay Foad <jay.foad at amd.com>
Date: Thu, 24 Sep 2026 08:46:42 +0100
Subject: [PATCH] [AMDGPU] Remove unneeded usesCustomInserter on some opcodes.
NFC.
---
llvm/lib/Target/AMDGPU/SIISelLowering.cpp | 5 -----
llvm/lib/Target/AMDGPU/VOP2Instructions.td | 2 +-
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/llvm/lib/Target/AMDGPU/SIISelLowering.cpp b/llvm/lib/Target/AMDGPU/SIISelLowering.cpp
index e47dd0e788796..9b93d48235126 100644
--- a/llvm/lib/Target/AMDGPU/SIISelLowering.cpp
+++ b/llvm/lib/Target/AMDGPU/SIISelLowering.cpp
@@ -7322,11 +7322,6 @@ SITargetLowering::EmitInstrWithCustomInserter(MachineInstr &MI,
MI.eraseFromParent();
return BB;
}
- case AMDGPU::V_ADD_CO_U32_e32:
- case AMDGPU::V_SUB_CO_U32_e32:
- case AMDGPU::V_SUBREV_CO_U32_e32:
- // TODO: Remove usesCustomInserter from these instructions.
- return BB;
case AMDGPU::V_ADDC_U32_e32:
case AMDGPU::V_SUBB_U32_e32:
case AMDGPU::V_SUBBREV_U32_e32:
diff --git a/llvm/lib/Target/AMDGPU/VOP2Instructions.td b/llvm/lib/Target/AMDGPU/VOP2Instructions.td
index cab46c5efd5b3..8e0b23ca2de50 100644
--- a/llvm/lib/Target/AMDGPU/VOP2Instructions.td
+++ b/llvm/lib/Target/AMDGPU/VOP2Instructions.td
@@ -283,7 +283,7 @@ multiclass VOP2bInst <string opName,
let Uses = !if(useSGPRInput, [VCC, EXEC], [EXEC]), Defs = [VCC] in {
def _e32 : VOP2_Pseudo <opName, P, VOPPatOrNull<node,P>.ret>,
Commutable_REV<revOp#"_e32", !eq(revOp, opName)> {
- let usesCustomInserter = true;
+ let usesCustomInserter = useSGPRInput;
}
if P.HasExtSDWA then
More information about the llvm-commits
mailing list