[llvm] [DWARF][NFC] Support Roc Language (PR #225631)

Will Hawkins via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 23 03:03:53 PDT 2026


hawkinsw wrote:

> > There are unit-tests in LLVM that exercise the DW_LNAME_ APIs. Might want to check whether you can add a case there
> 
> The alternative would be to either write a test using assembly, or to leverage yaml2obj's DWARF support, if it extends far enough (I'm not confident it does, so the former is probably better).

I thought about `yaml2obj` -- thank you for confirming my hunch. I will absolutely use it for writing tests!

> 
> Also, this is clearly not NFC if there are user-visible changes in behaviour.

Absolutely understood. I think that my brain went in a different direction when thinking about NFC, but I will absolutely adjust the message!

Thank you the feedback!

https://github.com/llvm/llvm-project/pull/225631


More information about the llvm-commits mailing list