[llvm] [obj2yaml] Add Obj2Yaml ability to dump GOFF ESD records (PR #216151)

[James Henderson via llvm-commits]

================
@@ -74,7 +74,145 @@ Error GOFFDumper::dumpHeader(ArrayRef<uint8_t> Data) {
 }
 
 Error GOFFDumper::dumpExternalSymbol(ArrayRef<uint8_t> Data) {
-  // TODO: Implement dumping ESD records
+  GOFFYAML::ESDRecord Sym;
+  // Flattened data contains PTV header (bytes 0-2) + bytes 3-72 (prefix) + name
+  // data. Use DataExtractor to read fields with correct endianness (big-endian
+  // for GOFF)
+  DataExtractor DE(Data, false); // false = big-endian
----------------
jh7370 wrote:

Nit: Normal style would be `DataExtractor DE(Data, /*ParamName=*/false);` (where `ParamName` is replaced with the actual parameter name). That should be equally descriptive and more idiomatic.

https://github.com/llvm/llvm-project/pull/216151