[llvm] [ORC] Remove unused rt_alt UnwindInfoManager CI names (PR #225329)
Lang Hames via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 22 01:35:02 PDT 2026
https://github.com/lhames created https://github.com/llvm/llvm-project/pull/225329
The rt_alt UnwindInfoManager register/deregister action names were added as a step towards supporting an "ORC-runtime-lite" API within LLVM, but have not been used so far. This patch removes them, rather than leaving them to drift. Replacements can be added as part of a coherent design when ORC-runtime-lite is revisited.
>From 1621cf44d58a16e15b0add968f06af4c7e93a38a Mon Sep 17 00:00:00 2001
From: Lang Hames <lhames at gmail.com>
Date: Tue, 22 Sep 2026 17:16:13 +1000
Subject: [PATCH] [ORC] Remove unused rt_alt UnwindInfoManager CI names
The rt_alt UnwindInfoManager register/deregister action names were added
as a step towards supporting an "ORC-runtime-lite" API within LLVM, but
have not been used so far. This patch removes them, rather than leaving
them to drift. Replacements can be added as part of a coherent design
when ORC-runtime-lite is revisited.
---
.../ExecutionEngine/Orc/Shared/OrcRTBridge.h | 5 -----
.../ExecutionEngine/Orc/Shared/OrcRTBridge.cpp | 7 -------
.../Orc/TargetProcess/UnwindInfoManager.cpp | 17 +++++------------
3 files changed, 5 insertions(+), 24 deletions(-)
diff --git a/llvm/include/llvm/ExecutionEngine/Orc/Shared/OrcRTBridge.h b/llvm/include/llvm/ExecutionEngine/Orc/Shared/OrcRTBridge.h
index 5f867edf07869..58c17810f56b8 100644
--- a/llvm/include/llvm/ExecutionEngine/Orc/Shared/OrcRTBridge.h
+++ b/llvm/include/llvm/ExecutionEngine/Orc/Shared/OrcRTBridge.h
@@ -45,11 +45,6 @@ extern const LLVM_ABI MachOUnwindInfoRegistrarSymbolNames
orc_rt_MachOUnwindInfoRegistrarSPSSymbols;
} // end namespace rt
-
-namespace rt_alt {
-LLVM_ABI extern const SymbolNameSpec UnwindInfoManagerRegisterActionName;
-LLVM_ABI extern const SymbolNameSpec UnwindInfoManagerDeregisterActionName;
-} // end namespace rt_alt
} // end namespace orc
} // end namespace llvm
diff --git a/llvm/lib/ExecutionEngine/Orc/Shared/OrcRTBridge.cpp b/llvm/lib/ExecutionEngine/Orc/Shared/OrcRTBridge.cpp
index 72b414aefbd92..e76c8746374ab 100644
--- a/llvm/lib/ExecutionEngine/Orc/Shared/OrcRTBridge.cpp
+++ b/llvm/lib/ExecutionEngine/Orc/Shared/OrcRTBridge.cpp
@@ -35,12 +35,5 @@ const MachOUnwindInfoRegistrarSymbolNames
"orc_rt_ci_aa_sps_MachOUnwindInfoRegistrar_deregisterSections")};
} // end namespace rt
-namespace rt_alt {
-const SymbolNameSpec UnwindInfoManagerRegisterActionName =
- SymbolNameSpec::verbatim("orc_rt_alt_UnwindInfoManager_register");
-const SymbolNameSpec UnwindInfoManagerDeregisterActionName =
- SymbolNameSpec::verbatim("orc_rt_alt_UnwindInfoManager_deregister");
-
-} // end namespace rt_alt
} // end namespace orc
} // end namespace llvm
diff --git a/llvm/lib/ExecutionEngine/Orc/TargetProcess/UnwindInfoManager.cpp b/llvm/lib/ExecutionEngine/Orc/TargetProcess/UnwindInfoManager.cpp
index 7b91faf9ec1bb..49456ca66473c 100644
--- a/llvm/lib/ExecutionEngine/Orc/TargetProcess/UnwindInfoManager.cpp
+++ b/llvm/lib/ExecutionEngine/Orc/TargetProcess/UnwindInfoManager.cpp
@@ -110,20 +110,13 @@ bool UnwindInfoManager::TryEnable() {
void UnwindInfoManager::addBootstrapSymbols(StringMap<ExecutorAddr> &M) {
Mangler Mangle{Triple(sys::getProcessTriple())};
- M[Mangle.mangledCopy(rt_alt::UnwindInfoManagerRegisterActionName)] =
+ // Provide the symbols for the StandaloneMachOUnwindInfoRegistrar SPS
+ // interface in the ORC runtime.
+ const auto &SNs = rt::orc_rt_MachOUnwindInfoRegistrarSPSSymbols;
+ M[Mangle.mangledCopy(SNs.RegisterSectionsName)] =
ExecutorAddr::fromPtr(llvm_orc_rt_alt_UnwindInfoManager_register);
- M[Mangle.mangledCopy(rt_alt::UnwindInfoManagerDeregisterActionName)] =
+ M[Mangle.mangledCopy(SNs.DeregisterSectionsName)] =
ExecutorAddr::fromPtr(llvm_orc_rt_alt_UnwindInfoManager_deregister);
-
- {
- // Also provide symbols defined by StandaloneMachOUnwindInfoRegistrar
- // in the new ORC runtime.
- const auto &SNs = rt::orc_rt_MachOUnwindInfoRegistrarSPSSymbols;
- M[Mangle.mangledCopy(SNs.RegisterSectionsName)] =
- ExecutorAddr::fromPtr(llvm_orc_rt_alt_UnwindInfoManager_register);
- M[Mangle.mangledCopy(SNs.DeregisterSectionsName)] =
- ExecutorAddr::fromPtr(llvm_orc_rt_alt_UnwindInfoManager_deregister);
- }
}
Error UnwindInfoManager::registerSections(
More information about the llvm-commits
mailing list