[llvm] [llvm] Remove declarations without definitions (NFC) (PR #225320)
Kazu Hirata via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 22 00:53:24 PDT 2026
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/225320
DataRecordHandle::create and DataRecordHandle::construct in
llvm/lib/CAS/OnDiskGraphDB.cpp: The unused definitions were removed on
November 24, 2025 in commit f21857313dfab543e66ef43b1aed43b685794a7c.
dwarf_linker::parallel::DwarfEmitterImpl::emitStringsImpl in
llvm/lib/DWARFLinker/Parallel/DWARFEmitterImpl.h: Added on May 20, 2023
in commit 5f2a7fa67e9b6081a1a750ecea1216d53287eaa0 without a definition
or any callers (only DWARFLinkerImpl::emitStringsImpl was defined).
dwarf_linker::parallel::SyntheticTypeNameBuilder::addOrderedName
(2-argument overload) in
llvm/lib/DWARFLinker/Parallel/SyntheticTypeNameBuilder.h: Added on
November 23, 2023 in commit b61ac4a88f934ab5c02ee2a4957fb1b9943e7a5d
without a definition or any callers.
pdb::GSIHashStreamBuilder::finalizePublicBuckets and
pdb::GSIHashStreamBuilder::finalizeGlobalBuckets in
llvm/lib/DebugInfo/PDB/Native/GSIStreamBuilder.cpp: Added on June 4,
2020 in commit b7402edce3150591df03b7352fdcb3336098d603 without
definitions or any callers (only the corresponding methods on
GSIStreamBuilder were defined).
jitlink::COFFLinkGraphBuilder::getPointerSize and
jitlink::COFFLinkGraphBuilder::getEndianness in
llvm/lib/ExecutionEngine/JITLink/COFFLinkGraphBuilder.h: The definitions
and callers were removed on January 14, 2025 in commit
4eaff6c58ae2f130ac8d63cf2c87bbb483114876.
jitlink::MachOLinkGraphBuilder::getPointerSize and
jitlink::MachOLinkGraphBuilder::getEndianness in
llvm/lib/ExecutionEngine/JITLink/MachOLinkGraphBuilder.h: The
definitions and callers were removed on January 14, 2025 in commit
4eaff6c58ae2f130ac8d63cf2c87bbb483114876.
EPCIndirectStubsManager::deallocateStubs in
llvm/lib/ExecutionEngine/Orc/EPCIndirectionUtils.cpp: Added on July 16,
2020 in commit 0e940d55f8a9388c42cc5998ea05212a983f05a7 without a
definition or any callers.
RuntimeDyldCheckerImpl::lookup and
RuntimeDyldCheckerImpl::getSectionLoadAddress in
llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldCheckerImpl.h: The
definitions and callers were removed on April 8, 2019 in commit
941f247d30c447903107aa614ea46fb1e4019698.
objcopy::macho::MachOReader::readCodeSignature in
llvm/lib/ObjCopy/MachO/MachOReader.h: The definition and caller were
removed on October 26, 2021 in commit
a299b24712ccd0769ffa0d5b65cbc98211fd4d99.
TGParser::ParseOptionalBitList in llvm/lib/TableGen/TGParser.h: The
definition and caller were removed on March 19, 2026 in commit
d29c6a34255e635b8ad794d21cdd0a2ed8820b68.
LoopIdiomVectorize::runOnCountableLoop in
llvm/lib/Transforms/Vectorize/LoopIdiomVectorize.cpp: Added on June 7,
2024 in commit 37e309f1635404bfca029c3712ee227a892cd4cf without a
definition or any callers.
Assisted-by: Antigravity
>From d560d6da23b21f789b2d4c42207d1a4f4f726a46 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Sat, 19 Sep 2026 16:50:41 -0700
Subject: [PATCH] [llvm] Remove declarations without definitions (NFC)
DataRecordHandle::create and DataRecordHandle::construct in
llvm/lib/CAS/OnDiskGraphDB.cpp: The unused definitions were removed on
November 24, 2025 in commit f21857313dfab543e66ef43b1aed43b685794a7c.
dwarf_linker::parallel::DwarfEmitterImpl::emitStringsImpl in
llvm/lib/DWARFLinker/Parallel/DWARFEmitterImpl.h: Added on May 20, 2023
in commit 5f2a7fa67e9b6081a1a750ecea1216d53287eaa0 without a definition
or any callers (only DWARFLinkerImpl::emitStringsImpl was defined).
dwarf_linker::parallel::SyntheticTypeNameBuilder::addOrderedName
(2-argument overload) in
llvm/lib/DWARFLinker/Parallel/SyntheticTypeNameBuilder.h: Added on
November 23, 2023 in commit b61ac4a88f934ab5c02ee2a4957fb1b9943e7a5d
without a definition or any callers.
pdb::GSIHashStreamBuilder::finalizePublicBuckets and
pdb::GSIHashStreamBuilder::finalizeGlobalBuckets in
llvm/lib/DebugInfo/PDB/Native/GSIStreamBuilder.cpp: Added on June 4,
2020 in commit b7402edce3150591df03b7352fdcb3336098d603 without
definitions or any callers (only the corresponding methods on
GSIStreamBuilder were defined).
jitlink::COFFLinkGraphBuilder::getPointerSize and
jitlink::COFFLinkGraphBuilder::getEndianness in
llvm/lib/ExecutionEngine/JITLink/COFFLinkGraphBuilder.h: The definitions
and callers were removed on January 14, 2025 in commit
4eaff6c58ae2f130ac8d63cf2c87bbb483114876.
jitlink::MachOLinkGraphBuilder::getPointerSize and
jitlink::MachOLinkGraphBuilder::getEndianness in
llvm/lib/ExecutionEngine/JITLink/MachOLinkGraphBuilder.h: The
definitions and callers were removed on January 14, 2025 in commit
4eaff6c58ae2f130ac8d63cf2c87bbb483114876.
EPCIndirectStubsManager::deallocateStubs in
llvm/lib/ExecutionEngine/Orc/EPCIndirectionUtils.cpp: Added on July 16,
2020 in commit 0e940d55f8a9388c42cc5998ea05212a983f05a7 without a
definition or any callers.
RuntimeDyldCheckerImpl::lookup and
RuntimeDyldCheckerImpl::getSectionLoadAddress in
llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldCheckerImpl.h: The
definitions and callers were removed on April 8, 2019 in commit
941f247d30c447903107aa614ea46fb1e4019698.
objcopy::macho::MachOReader::readCodeSignature in
llvm/lib/ObjCopy/MachO/MachOReader.h: The definition and caller were
removed on October 26, 2021 in commit
a299b24712ccd0769ffa0d5b65cbc98211fd4d99.
TGParser::ParseOptionalBitList in llvm/lib/TableGen/TGParser.h: The
definition and caller were removed on March 19, 2026 in commit
d29c6a34255e635b8ad794d21cdd0a2ed8820b68.
LoopIdiomVectorize::runOnCountableLoop in
llvm/lib/Transforms/Vectorize/LoopIdiomVectorize.cpp: Added on June 7,
2024 in commit 37e309f1635404bfca029c3712ee227a892cd4cf without a
definition or any callers.
Assisted-by: Antigravity
---
llvm/lib/CAS/OnDiskGraphDB.cpp | 3 ---
llvm/lib/DWARFLinker/Parallel/DWARFEmitterImpl.h | 10 ----------
.../DWARFLinker/Parallel/SyntheticTypeNameBuilder.h | 3 ---
llvm/lib/DebugInfo/PDB/Native/GSIStreamBuilder.cpp | 3 ---
.../lib/ExecutionEngine/JITLink/COFFLinkGraphBuilder.h | 2 --
.../ExecutionEngine/JITLink/MachOLinkGraphBuilder.h | 3 ---
llvm/lib/ExecutionEngine/Orc/EPCIndirectionUtils.cpp | 2 --
.../RuntimeDyld/RuntimeDyldCheckerImpl.h | 5 -----
llvm/lib/ObjCopy/MachO/MachOReader.h | 1 -
llvm/lib/TableGen/TGParser.h | 1 -
llvm/lib/Transforms/Vectorize/LoopIdiomVectorize.cpp | 1 -
11 files changed, 34 deletions(-)
diff --git a/llvm/lib/CAS/OnDiskGraphDB.cpp b/llvm/lib/CAS/OnDiskGraphDB.cpp
index 7626e0181fd7c..ffec3c3dbe8ae 100644
--- a/llvm/lib/CAS/OnDiskGraphDB.cpp
+++ b/llvm/lib/CAS/OnDiskGraphDB.cpp
@@ -324,12 +324,9 @@ struct DataRecordHandle {
getDataSize());
}
- static DataRecordHandle create(function_ref<char *(size_t Size)> Alloc,
- const Input &I);
static Expected<DataRecordHandle>
createWithError(function_ref<Expected<char *>(size_t Size)> Alloc,
const Input &I);
- static DataRecordHandle construct(char *Mem, const Input &I);
static DataRecordHandle get(const char *Mem) {
return DataRecordHandle(
diff --git a/llvm/lib/DWARFLinker/Parallel/DWARFEmitterImpl.h b/llvm/lib/DWARFLinker/Parallel/DWARFEmitterImpl.h
index 1496c1dbbff1b..63f64b13e0db7 100644
--- a/llvm/lib/DWARFLinker/Parallel/DWARFEmitterImpl.h
+++ b/llvm/lib/DWARFLinker/Parallel/DWARFEmitterImpl.h
@@ -92,16 +92,6 @@ class DwarfEmitterImpl {
void emitAppleTypes(AccelTable<AppleAccelTableStaticTypeData> &Table);
private:
- // Enumerate all string patches and write them into the destination section.
- // Order of patches is the same as in original input file. To avoid emitting
- // the same string twice we accumulate NextOffset value. Thus if string
- // offset smaller than NextOffset value then the patch is skipped (as that
- // string was emitted earlier).
- template <typename PatchTy>
- void emitStringsImpl(ArrayList<PatchTy> &StringPatches,
- const StringEntryToDwarfStringPoolEntryMap &Strings,
- uint64_t &NextOffset, MCSection *OutSection);
-
/// \defgroup MCObjects MC layer objects constructed by the streamer
/// @{
MCTargetOptions MCOptions;
diff --git a/llvm/lib/DWARFLinker/Parallel/SyntheticTypeNameBuilder.h b/llvm/lib/DWARFLinker/Parallel/SyntheticTypeNameBuilder.h
index 3a7ad0a3058ef..89a65ea36dab1 100644
--- a/llvm/lib/DWARFLinker/Parallel/SyntheticTypeNameBuilder.h
+++ b/llvm/lib/DWARFLinker/Parallel/SyntheticTypeNameBuilder.h
@@ -72,9 +72,6 @@ class SyntheticTypeNameBuilder {
CompileUnit &CU,
SmallVector<const DWARFDebugInfoEntry *, 10> &TemplateParameters);
- /// Add ordered name to the built name.
- void addOrderedName(CompileUnit &CU, const DWARFDebugInfoEntry *DieEntry);
-
/// Analyze \p InputUnitEntryPair's ODR attributes and put names
/// of the referenced type dies to the built name.
Error addReferencedODRDies(UnitEntryPairTy InputUnitEntryPair,
diff --git a/llvm/lib/DebugInfo/PDB/Native/GSIStreamBuilder.cpp b/llvm/lib/DebugInfo/PDB/Native/GSIStreamBuilder.cpp
index 1c76139824667..6f0d39ac9c162 100644
--- a/llvm/lib/DebugInfo/PDB/Native/GSIStreamBuilder.cpp
+++ b/llvm/lib/DebugInfo/PDB/Native/GSIStreamBuilder.cpp
@@ -55,9 +55,6 @@ struct llvm::pdb::GSIHashStreamBuilder {
uint32_t calculateSerializedLength() const;
Error commit(BinaryStreamWriter &Writer);
- void finalizePublicBuckets();
- void finalizeGlobalBuckets(uint32_t RecordZeroOffset);
-
// Assign public and global symbol records into hash table buckets.
// Modifies the list of records to store the bucket index, but does not
// change the order.
diff --git a/llvm/lib/ExecutionEngine/JITLink/COFFLinkGraphBuilder.h b/llvm/lib/ExecutionEngine/JITLink/COFFLinkGraphBuilder.h
index a8ad781da1558..171a30e1bfb9a 100644
--- a/llvm/lib/ExecutionEngine/JITLink/COFFLinkGraphBuilder.h
+++ b/llvm/lib/ExecutionEngine/JITLink/COFFLinkGraphBuilder.h
@@ -166,8 +166,6 @@ class COFFLinkGraphBuilder {
static uint64_t getSectionSize(const object::COFFObjectFile &Obj,
const object::coff_section *Section);
static bool isComdatSection(const object::coff_section *Section);
- static unsigned getPointerSize(const object::COFFObjectFile &Obj);
- static llvm::endianness getEndianness(const object::COFFObjectFile &Obj);
static StringRef getDLLImportStubPrefix() { return "__imp_"; }
static StringRef getDirectiveSectionName() { return ".drectve"; }
StringRef getCOFFSectionName(COFFSectionIndex SectionIndex,
diff --git a/llvm/lib/ExecutionEngine/JITLink/MachOLinkGraphBuilder.h b/llvm/lib/ExecutionEngine/JITLink/MachOLinkGraphBuilder.h
index 91021e457532e..cf9304f932b0b 100644
--- a/llvm/lib/ExecutionEngine/JITLink/MachOLinkGraphBuilder.h
+++ b/llvm/lib/ExecutionEngine/JITLink/MachOLinkGraphBuilder.h
@@ -178,9 +178,6 @@ class MachOLinkGraphBuilder {
}
private:
- static unsigned getPointerSize(const object::MachOObjectFile &Obj);
- static llvm::endianness getEndianness(const object::MachOObjectFile &Obj);
-
void setCanonicalSymbol(NormalizedSection &NSec, Symbol &Sym) {
auto *&CanonicalSymEntry = NSec.CanonicalSymbols[Sym.getAddress()];
// There should be no symbol at this address, or, if there is,
diff --git a/llvm/lib/ExecutionEngine/Orc/EPCIndirectionUtils.cpp b/llvm/lib/ExecutionEngine/Orc/EPCIndirectionUtils.cpp
index 8bdfdc5ed44bb..e71e176965700 100644
--- a/llvm/lib/ExecutionEngine/Orc/EPCIndirectionUtils.cpp
+++ b/llvm/lib/ExecutionEngine/Orc/EPCIndirectionUtils.cpp
@@ -57,8 +57,6 @@ class EPCIndirectStubsManager : public IndirectStubsManager,
public:
EPCIndirectStubsManager(EPCIndirectionUtils &EPCIU) : EPCIU(EPCIU) {}
- Error deallocateStubs();
-
Error createStub(StringRef StubName, ExecutorAddr StubAddr,
JITSymbolFlags StubFlags) override;
diff --git a/llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldCheckerImpl.h b/llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldCheckerImpl.h
index bda554e9e5b67..b4c44f06a2679 100644
--- a/llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldCheckerImpl.h
+++ b/llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldCheckerImpl.h
@@ -43,9 +43,6 @@ class RuntimeDyldCheckerImpl {
// StubMap typedefs.
- Expected<JITSymbolResolver::LookupResult>
- lookup(const JITSymbolResolver::LookupSet &Symbols) const;
-
bool isSymbolValid(StringRef Symbol) const;
uint64_t getSymbolLocalAddr(StringRef Symbol) const;
uint64_t getSymbolRemoteAddr(StringRef Symbol) const;
@@ -67,8 +64,6 @@ class RuntimeDyldCheckerImpl {
StringRef StubKindFilter, bool IsInsideLoad,
bool IsStubAddr) const;
- std::optional<uint64_t> getSectionLoadAddress(void *LocalAddr) const;
-
IsSymbolValidFunction IsSymbolValid;
GetSymbolInfoFunction GetSymbolInfo;
GetSectionInfoFunction GetSectionInfo;
diff --git a/llvm/lib/ObjCopy/MachO/MachOReader.h b/llvm/lib/ObjCopy/MachO/MachOReader.h
index 940ba4c2d879e..a88885d568179 100644
--- a/llvm/lib/ObjCopy/MachO/MachOReader.h
+++ b/llvm/lib/ObjCopy/MachO/MachOReader.h
@@ -41,7 +41,6 @@ class MachOReader : public Reader {
void readExportInfo(Object &O) const;
void readLinkData(Object &O, std::optional<size_t> LCIndex,
LinkData &LD) const;
- void readCodeSignature(Object &O) const;
void readDataInCodeData(Object &O) const;
void readLinkerOptimizationHint(Object &O) const;
void readFunctionStartsData(Object &O) const;
diff --git a/llvm/lib/TableGen/TGParser.h b/llvm/lib/TableGen/TGParser.h
index 9da1ecc5e60d0..f699e9920cb60 100644
--- a/llvm/lib/TableGen/TGParser.h
+++ b/llvm/lib/TableGen/TGParser.h
@@ -317,7 +317,6 @@ class TGParser {
SmallVectorImpl<std::pair<const Init *, const StringInit *>> &Result,
Record *CurRec);
bool ParseOptionalRangeList(SmallVectorImpl<unsigned> &Ranges);
- bool ParseOptionalBitList(SmallVectorImpl<unsigned> &Ranges);
const TypedInit *ParseSliceElement(Record *CurRec);
const TypedInit *ParseSliceElements(Record *CurRec, bool Single = false);
void ParseRangeList(SmallVectorImpl<unsigned> &Result);
diff --git a/llvm/lib/Transforms/Vectorize/LoopIdiomVectorize.cpp b/llvm/lib/Transforms/Vectorize/LoopIdiomVectorize.cpp
index 39869186ce963..6f59921d9a11e 100644
--- a/llvm/lib/Transforms/Vectorize/LoopIdiomVectorize.cpp
+++ b/llvm/lib/Transforms/Vectorize/LoopIdiomVectorize.cpp
@@ -148,7 +148,6 @@ class LoopIdiomVectorize {
/// \name Countable Loop Idiom Handling
/// @{
- bool runOnCountableLoop();
bool runOnLoopBlock(BasicBlock *BB, const SCEV *BECount,
SmallVectorImpl<BasicBlock *> &ExitBlocks);
More information about the llvm-commits
mailing list