[llvm] [TargetLowering][COFF] Only check shouldAssumeDSOLocal on GlobalVariable in lowerRelativeReference (PR #225160)

Eli Friedman via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 21 11:46:39 PDT 2026


https://github.com/efriedma-quic commented:

This handling is not theoretically sound, I think.  If you refer to a dllimport function from a global like this, you get some pointer, but not *the* pointer (which is unique across the whole program).  We probably need something like dso_local_equivalent (https://llvm.org/docs/LangRef.html#dso-local-equivalent).

But I'm okay with taking this as a quick fix if you leave a FIXME explaining the issue.

https://github.com/llvm/llvm-project/pull/225160


More information about the llvm-commits mailing list