[llvm] [orc-rt] Implement Windows CPU feature detection (PR #224516)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 21 03:10:22 PDT 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- orc-rt/lib/bedrock/sys/windows/CPUFeatures.cpp orc-rt/lib/bedrock/sys/windows/TargetTriple.cpp orc-rt/test/unit/bedrock/sys/CPUFeaturesTest.cpp orc-rt/test/unit/bedrock/sys/TargetTripleTest.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/orc-rt/test/unit/bedrock/sys/CPUFeaturesTest.cpp b/orc-rt/test/unit/bedrock/sys/CPUFeaturesTest.cpp
index 54304b5f8..fa5d89595 100644
--- a/orc-rt/test/unit/bedrock/sys/CPUFeaturesTest.cpp
+++ b/orc-rt/test/unit/bedrock/sys/CPUFeaturesTest.cpp
@@ -32,8 +32,7 @@ TEST(CPUFeaturesTest, CachedResultIsIdempotent) {
TEST(CPUFeaturesTest, DetectsBaselineX86Features) {
auto Features = sys::detectTargetCPUFeatures();
- EXPECT_NE(std::find(Features.begin(), Features.end(), "sse"),
- Features.end());
+ EXPECT_NE(std::find(Features.begin(), Features.end(), "sse"), Features.end());
EXPECT_NE(std::find(Features.begin(), Features.end(), "sse2"),
Features.end());
}
diff --git a/orc-rt/test/unit/bedrock/sys/TargetTripleTest.cpp b/orc-rt/test/unit/bedrock/sys/TargetTripleTest.cpp
index ad1a230da..76e612415 100644
--- a/orc-rt/test/unit/bedrock/sys/TargetTripleTest.cpp
+++ b/orc-rt/test/unit/bedrock/sys/TargetTripleTest.cpp
@@ -48,11 +48,11 @@ TEST(TargetTripleTest, OSMatchesCompileTarget) {
auto Triple = sys::detectTargetTriple();
#if defined(__APPLE__)
- EXPECT_NE(Triple.find("-apple-"), std::string::npos);
+ EXPECT_NE(Triple.find("-apple-"), std::string::npos);
#elif defined(__linux__)
- EXPECT_NE(Triple.find("-linux-"), std::string::npos);
+ EXPECT_NE(Triple.find("-linux-"), std::string::npos);
#elif defined(_WIN32)
- EXPECT_NE(Triple.find("-windows-"), std::string::npos);
+ EXPECT_NE(Triple.find("-windows-"), std::string::npos);
#endif
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/224516
More information about the llvm-commits
mailing list