[llvm] [llvm-pdbutil] Avoid reading EC names from non-EC modules (PR #223253)

via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 16 02:18:19 PDT 2026


================
@@ -503,15 +503,21 @@ Error DumpOutputStyle::dumpModules() {
                      Desc.getModuleStreamIndex(), Desc.getNumberOfFiles(),
                      Desc.hasECInfo());
 
-        auto PdbPathOrErr = Stream.getECName(Desc.getPdbFilePathNameIndex());
-        if (!PdbPathOrErr)
-          return PdbPathOrErr.takeError();
-        StringRef PdbFilePath = *PdbPathOrErr;
-
-        auto SrcPathOrErr = Stream.getECName(Desc.getSourceFileNameIndex());
-        if (!SrcPathOrErr)
-          return SrcPathOrErr.takeError();
-        StringRef SrcFilePath = *SrcPathOrErr;
+        StringRef PdbFilePath;
+        if (Desc.getPdbFilePathNameIndex() != 0) {
+          auto PdbPathOrErr = Stream.getECName(Desc.getPdbFilePathNameIndex());
+          if (!PdbPathOrErr)
+            return PdbPathOrErr.takeError();
+          PdbFilePath = *PdbPathOrErr;
+        }
+
+        StringRef SrcFilePath;
+        if (Desc.getSourceFileNameIndex()) {
----------------
Nerixyz wrote:

You can merge this `if` with the one above.

https://github.com/llvm/llvm-project/pull/223253


More information about the llvm-commits mailing list