[llvm] [CMake] Fix message type mistake (PR #174947)

via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 15 04:26:12 PDT 2026


https://github.com/ferdymercury updated https://github.com/llvm/llvm-project/pull/174947

>From 0019071a04d64f7eebd11730bc23ace0f3d4b9ad Mon Sep 17 00:00:00 2001
From: ferdymercury <ferdymercury at users.noreply.github.com>
Date: Thu, 8 Jan 2026 12:05:33 +0100
Subject: [PATCH 1/2] [CMake] Fix message type mistake

ERROR does not exist, either SEND_ERROR or FATAL_ERROR
---
 llvm/cmake/modules/HandleLLVMOptions.cmake | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/cmake/modules/HandleLLVMOptions.cmake b/llvm/cmake/modules/HandleLLVMOptions.cmake
index 397aa0a6e0766..d0df3aa809e58 100644
--- a/llvm/cmake/modules/HandleLLVMOptions.cmake
+++ b/llvm/cmake/modules/HandleLLVMOptions.cmake
@@ -592,7 +592,7 @@ if( MSVC )
 
   if (LLVM_WINSYSROOT)
     if (NOT CLANG_CL)
-      message(ERROR "LLVM_WINSYSROOT requires clang-cl")
+      message(SEND_ERROR "LLVM_WINSYSROOT requires clang-cl")
     endif()
     append("/winsysroot${LLVM_WINSYSROOT}" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
     if (LINKER_IS_LLD_LINK)

>From 882b39daa2016af19b355729d89ce62f023b7da8 Mon Sep 17 00:00:00 2001
From: ferdymercury <ferdymercury at users.noreply.github.com>
Date: Tue, 15 Sep 2026 13:26:02 +0200
Subject: [PATCH 2/2] Fatal_error instead of send_error

---
 llvm/cmake/modules/HandleLLVMOptions.cmake | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/cmake/modules/HandleLLVMOptions.cmake b/llvm/cmake/modules/HandleLLVMOptions.cmake
index d0df3aa809e58..56efd06163a6b 100644
--- a/llvm/cmake/modules/HandleLLVMOptions.cmake
+++ b/llvm/cmake/modules/HandleLLVMOptions.cmake
@@ -592,7 +592,7 @@ if( MSVC )
 
   if (LLVM_WINSYSROOT)
     if (NOT CLANG_CL)
-      message(SEND_ERROR "LLVM_WINSYSROOT requires clang-cl")
+      message(FATAL_ERROR "LLVM_WINSYSROOT requires clang-cl")
     endif()
     append("/winsysroot${LLVM_WINSYSROOT}" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
     if (LINKER_IS_LLD_LINK)



More information about the llvm-commits mailing list