[llvm] [GVN] Deduplicate compare expressions creation (NFC) (PR #223389)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 14 05:47:15 PDT 2026
llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-transforms
Author: Antonio Frighetto (antoniofrighetto)
<details>
<summary>Changes</summary>
Minor opportunity to create GVN expressions for cmp instructions via existing dedicated `createCmpExpr` handler.
---
Full diff: https://github.com/llvm/llvm-project/pull/223389.diff
2 Files Affected:
- (modified) llvm/include/llvm/Transforms/Scalar/GVN.h (+1-1)
- (modified) llvm/lib/Transforms/Scalar/GVN.cpp (+8-14)
``````````diff
diff --git a/llvm/include/llvm/Transforms/Scalar/GVN.h b/llvm/include/llvm/Transforms/Scalar/GVN.h
index 82684dcafc0f4..19a9113f7ffaa 100644
--- a/llvm/include/llvm/Transforms/Scalar/GVN.h
+++ b/llvm/include/llvm/Transforms/Scalar/GVN.h
@@ -192,7 +192,7 @@ class GVNPass : public OptionalPassInfoMixin<GVNPass> {
Expression createExpr(Instruction *I);
Expression createCmpExpr(unsigned Opcode, CmpInst::Predicate Predicate,
Value *LHS, Value *RHS);
- Expression createExtractvalueExpr(ExtractValueInst *EI);
+ Expression createExtractValueExpr(ExtractValueInst *EI);
Expression createGEPExpr(GetElementPtrInst *GEP);
uint32_t lookupOrAddCall(CallInst *C);
uint32_t computeLoadStoreVN(Instruction *I);
diff --git a/llvm/lib/Transforms/Scalar/GVN.cpp b/llvm/lib/Transforms/Scalar/GVN.cpp
index c8989a4c8e0d4..7eee9a7b164aa 100644
--- a/llvm/lib/Transforms/Scalar/GVN.cpp
+++ b/llvm/lib/Transforms/Scalar/GVN.cpp
@@ -357,16 +357,7 @@ GVNPass::Expression GVNPass::ValueTable::createExpr(Instruction *I) {
E.Commutative = true;
}
- if (auto *C = dyn_cast<CmpInst>(I)) {
- // Sort the operand value numbers so x<y and y>x get the same value number.
- CmpInst::Predicate Predicate = C->getPredicate();
- if (E.VarArgs[0] > E.VarArgs[1]) {
- std::swap(E.VarArgs[0], E.VarArgs[1]);
- Predicate = CmpInst::getSwappedPredicate(Predicate);
- }
- E.Opcode = (C->getOpcode() << 8) | Predicate;
- E.Commutative = true;
- } else if (auto *IVI = dyn_cast<InsertValueInst>(I)) {
+ if (auto *IVI = dyn_cast<InsertValueInst>(I)) {
E.VarArgs.append(IVI->idx_begin(), IVI->idx_end());
} else if (auto *SVI = dyn_cast<ShuffleVectorInst>(I)) {
ArrayRef<int> ShuffleMask = SVI->getShuffleMask();
@@ -398,7 +389,7 @@ GVNPass::Expression GVNPass::ValueTable::createCmpExpr(
}
GVNPass::Expression
-GVNPass::ValueTable::createExtractvalueExpr(ExtractValueInst *EI) {
+GVNPass::ValueTable::createExtractValueExpr(ExtractValueInst *EI) {
assert(EI && "Not an ExtractValueInst?");
Expression E;
E.Ty = EI->getType();
@@ -697,8 +688,6 @@ uint32_t GVNPass::ValueTable::lookupOrAdd(Value *V) {
case Instruction::And:
case Instruction::Or:
case Instruction::Xor:
- case Instruction::ICmp:
- case Instruction::FCmp:
case Instruction::Trunc:
case Instruction::ZExt:
case Instruction::SExt:
@@ -721,11 +710,16 @@ uint32_t GVNPass::ValueTable::lookupOrAdd(Value *V) {
case Instruction::InsertValue:
Exp = createExpr(I);
break;
+ case Instruction::ICmp:
+ case Instruction::FCmp:
+ Exp = createCmpExpr(I->getOpcode(), cast<CmpInst>(I)->getPredicate(),
+ I->getOperand(0), I->getOperand(1));
+ break;
case Instruction::GetElementPtr:
Exp = createGEPExpr(cast<GetElementPtrInst>(I));
break;
case Instruction::ExtractValue:
- Exp = createExtractvalueExpr(cast<ExtractValueInst>(I));
+ Exp = createExtractValueExpr(cast<ExtractValueInst>(I));
break;
case Instruction::PHI:
ValueNumbering[V] = NextValueNumber;
``````````
</details>
https://github.com/llvm/llvm-project/pull/223389
More information about the llvm-commits
mailing list