[compiler-rt] [compiler-rt] Set FILEOS and FILETYPE in windows_version_resource.rc (PR #223387)

[via llvm-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-platform-windows

Author: Hans Wennborg (zmodem)

<details>
<summary>Changes</summary>

This is a follow-up to #<!-- -->216408 which added version info to runtime DLLs.

We have a test (in Crashpad) that expects the FILEOS and FILETYPE to be set. I suppose it was getting default values from somewhere before, but after #<!-- -->216408 it fails unless we set them explicitly.

---
Full diff: https://github.com/llvm/llvm-project/pull/223387.diff


1 Files Affected:

- (modified) compiler-rt/resources/windows_version_resource.rc (+2) 


``````````diff
diff --git a/compiler-rt/resources/windows_version_resource.rc b/compiler-rt/resources/windows_version_resource.rc
index 6b1645cb3ef39..ba6fa4f852ccf 100644
--- a/compiler-rt/resources/windows_version_resource.rc
+++ b/compiler-rt/resources/windows_version_resource.rc
@@ -54,6 +54,8 @@
 
 1 VERSIONINFO
 FILEVERSION RC_VERSION_FIELD_1,RC_VERSION_FIELD_2,RC_VERSION_FIELD_3,RC_VERSION_FIELD_4
+FILEOS 0x40004  // VOS_NT_WINDOWS32
+FILETYPE 0x2    // VFT_DLL
 BEGIN
   BLOCK "StringFileInfo"
   BEGIN

``````````

</details>


https://github.com/llvm/llvm-project/pull/223387