[llvm] [lli] Honor explicit emulated TLS option in ORC mode (PR #217554)
Lang Hames via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 14 01:42:26 PDT 2026
https://github.com/lhames commented:
I think the `lli` change is good.
The testcase should probably be renamed to `tls.ll` since it's going to test native too.
I worry about this testcase. Not because of these changes, it's just always been a bit awkward. Could you add a TODO to replace it with positive "TLS works" tests in the new ORC runtime? (We can't write them yet, but will be able to soon)
Just flagging in advance: If the test does cause problems (we haven't verified clean errors for native TLS everywhere) that will almost certainly be a sign of missing error coverage and we should add the missing errors, but may need to revert this patch temporarily to get the bots green.
Otherwise LGTM.
https://github.com/llvm/llvm-project/pull/217554
More information about the llvm-commits
mailing list