[llvm] [ASan] Convert pointer-pair operands based on type (PR #218494)

[via llvm-commits]

im-lunex wrote:

> LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux` running on `sanitizer-buildbot7` while building `llvm` at step 2 "annotate".
> 
> Full details are available at: https://lab.llvm.org/buildbot/#/builders/51/builds/43799
> Here is the relevant piece of the build log for the reference
> 
> ```
> Step 2 (annotate) failure: 'python ../sanitizer_buildbot/sanitizers/zorg/buildbot/builders/sanitizers/buildbot_selector.py' (failure)
> ...
> [203/208] Generating MSAN_INST_GTEST.gtest-all.cc.aarch64-with-call.o
> [204/208] Generating MSAN_INST_TEST_OBJECTS.msan_test.cpp.aarch64-with-call.o
> [205/208] Generating Msan-aarch64-with-call-Test
> [206/208] Generating MSAN_INST_TEST_OBJECTS.msan_test.cpp.aarch64.o
> [207/208] Generating Msan-aarch64-Test
> [207/208] Running compiler_rt regression tests
> llvm-lit: /home/b/sanitizer-aarch64-linux/build/llvm-project/llvm/utils/lit/lit/discovery.py:273: warning: input '/home/b/sanitizer-aarch64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/test/interception/Unit' contained no tests
> llvm-lit: /home/b/sanitizer-aarch64-linux/build/llvm-project/llvm/utils/lit/lit/discovery.py:273: warning: input '/home/b/sanitizer-aarch64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/test/sanitizer_common/Unit' contained no tests
> -- Testing: 6522 tests, 72 workers --
> Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60..
> FAIL: LeakSanitizer-HWAddressSanitizer-aarch64 :: TestCases/create_thread_leak.cpp (4465 of 6522)
> ******************** TEST 'LeakSanitizer-HWAddressSanitizer-aarch64 :: TestCases/create_thread_leak.cpp' FAILED ********************
> Exit Code: 2
> 
> Command Output (stdout):
> --
> # RUN: at line 3
> /home/b/sanitizer-aarch64-linux/build/build_default/./bin/clang  --driver-mode=g++ -O0   -Wthread-safety -Wthread-safety-reference -Wthread-safety-beta   -gline-tables-only -fsanitize=hwaddress -fuse-ld=lld -I/home/b/sanitizer-aarch64-linux/build/llvm-project/compiler-rt/test/lsan/../ -pthread /home/b/sanitizer-aarch64-linux/build/llvm-project/compiler-rt/test/lsan/TestCases/create_thread_leak.cpp -o /home/b/sanitizer-aarch64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/test/lsan/AARCH64HWAsanConfig/TestCases/Output/create_thread_leak.cpp.tmp
> # executed command: /home/b/sanitizer-aarch64-linux/build/build_default/./bin/clang --driver-mode=g++ -O0 -Wthread-safety -Wthread-safety-reference -Wthread-safety-beta -gline-tables-only -fsanitize=hwaddress -fuse-ld=lld -I/home/b/sanitizer-aarch64-linux/build/llvm-project/compiler-rt/test/lsan/../ -pthread /home/b/sanitizer-aarch64-linux/build/llvm-project/compiler-rt/test/lsan/TestCases/create_thread_leak.cpp -o /home/b/sanitizer-aarch64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/test/lsan/AARCH64HWAsanConfig/TestCases/Output/create_thread_leak.cpp.tmp
> # note: command had no output on stdout or stderr
> # RUN: at line 4
> not  /home/b/sanitizer-aarch64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/test/lsan/AARCH64HWAsanConfig/TestCases/Output/create_thread_leak.cpp.tmp 10 1 0 0 2>&1 | FileCheck /home/b/sanitizer-aarch64-linux/build/llvm-project/compiler-rt/test/lsan/TestCases/create_thread_leak.cpp --check-prefixes=LEAK,LEAK123
> # executed command: not /home/b/sanitizer-aarch64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/test/lsan/AARCH64HWAsanConfig/TestCases/Output/create_thread_leak.cpp.tmp 10 1 0 0
> # note: command had no output on stdout or stderr
> # executed command: FileCheck /home/b/sanitizer-aarch64-linux/build/llvm-project/compiler-rt/test/lsan/TestCases/create_thread_leak.cpp --check-prefixes=LEAK,LEAK123
> # note: command had no output on stdout or stderr
> # RUN: at line 5
> not  /home/b/sanitizer-aarch64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/test/lsan/AARCH64HWAsanConfig/TestCases/Output/create_thread_leak.cpp.tmp 10 0 1 0 2>&1 | FileCheck /home/b/sanitizer-aarch64-linux/build/llvm-project/compiler-rt/test/lsan/TestCases/create_thread_leak.cpp --check-prefixes=LEAK,LEAK234
> # executed command: not /home/b/sanitizer-aarch64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/test/lsan/AARCH64HWAsanConfig/TestCases/Output/create_thread_leak.cpp.tmp 10 0 1 0
> # note: command had no output on stdout or stderr
> # executed command: FileCheck /home/b/sanitizer-aarch64-linux/build/llvm-project/compiler-rt/test/lsan/TestCases/create_thread_leak.cpp --check-prefixes=LEAK,LEAK234
> # note: command had no output on stdout or stderr
> # RUN: at line 6
> not  /home/b/sanitizer-aarch64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/test/lsan/AARCH64HWAsanConfig/TestCases/Output/create_thread_leak.cpp.tmp 10 0 0 1 2>&1 | FileCheck /home/b/sanitizer-aarch64-linux/build/llvm-project/compiler-rt/test/lsan/TestCases/create_thread_leak.cpp --check-prefixes=LEAK,LEAK234
> # executed command: not /home/b/sanitizer-aarch64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/test/lsan/AARCH64HWAsanConfig/TestCases/Output/create_thread_leak.cpp.tmp 10 0 0 1
> # note: command had no output on stdout or stderr
> # error: command failed with exit status: 1
> # executed command: FileCheck /home/b/sanitizer-aarch64-linux/build/llvm-project/compiler-rt/test/lsan/TestCases/create_thread_leak.cpp --check-prefixes=LEAK,LEAK234
> # .---command stderr------------
> # | FileCheck error: '<stdin>' is empty.
> # | FileCheck command line:  FileCheck /home/b/sanitizer-aarch64-linux/build/llvm-project/compiler-rt/test/lsan/TestCases/create_thread_leak.cpp --check-prefixes=LEAK,LEAK234
> # `-----------------------------
> # error: command failed with exit status: 2
> 
> --
> 
> ********************
> Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
> 
> Step 9 (test compiler-rt symbolizer) failure: test compiler-rt symbolizer (failure)
> ...
> [203/208] Generating MSAN_INST_GTEST.gtest-all.cc.aarch64-with-call.o
> [204/208] Generating MSAN_INST_TEST_OBJECTS.msan_test.cpp.aarch64-with-call.o
> [205/208] Generating Msan-aarch64-with-call-Test
> [206/208] Generating MSAN_INST_TEST_OBJECTS.msan_test.cpp.aarch64.o
> [207/208] Generating Msan-aarch64-Test
> [207/208] Running compiler_rt regression tests
> llvm-lit: /home/b/sanitizer-aarch64-linux/build/llvm-project/llvm/utils/lit/lit/discovery.py:273: warning: input '/home/b/sanitizer-aarch64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/test/interception/Unit' contained no tests
> llvm-lit: /home/b/sanitizer-aarch64-linux/build/llvm-project/llvm/utils/lit/lit/discovery.py:273: warning: input '/home/b/sanitizer-aarch64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/test/sanitizer_common/Unit' contained no tests
> -- Testing: 6522 tests, 72 workers --
> Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60..
> FAIL: LeakSanitizer-HWAddressSanitizer-aarch64 :: TestCases/create_thread_leak.cpp (4465 of 6522)
> ******************** TEST 'LeakSanitizer-HWAddressSanitizer-aarch64 :: TestCases/create_thread_leak.cpp' FAILED ********************
> Exit Code: 2
> 
> Command Output (stdout):
> --
> # RUN: at line 3
> /home/b/sanitizer-aarch64-linux/build/build_default/./bin/clang  --driver-mode=g++ -O0   -Wthread-safety -Wthread-safety-reference -Wthread-safety-beta   -gline-tables-only -fsanitize=hwaddress -fuse-ld=lld -I/home/b/sanitizer-aarch64-linux/build/llvm-project/compiler-rt/test/lsan/../ -pthread /home/b/sanitizer-aarch64-linux/build/llvm-project/compiler-rt/test/lsan/TestCases/create_thread_leak.cpp -o /home/b/sanitizer-aarch64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/test/lsan/AARCH64HWAsanConfig/TestCases/Output/create_thread_leak.cpp.tmp
> # executed command: /home/b/sanitizer-aarch64-linux/build/build_default/./bin/clang --driver-mode=g++ -O0 -Wthread-safety -Wthread-safety-reference -Wthread-safety-beta -gline-tables-only -fsanitize=hwaddress -fuse-ld=lld -I/home/b/sanitizer-aarch64-linux/build/llvm-project/compiler-rt/test/lsan/../ -pthread /home/b/sanitizer-aarch64-linux/build/llvm-project/compiler-rt/test/lsan/TestCases/create_thread_leak.cpp -o /home/b/sanitizer-aarch64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/test/lsan/AARCH64HWAsanConfig/TestCases/Output/create_thread_leak.cpp.tmp
> # note: command had no output on stdout or stderr
> # RUN: at line 4
> not  /home/b/sanitizer-aarch64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/test/lsan/AARCH64HWAsanConfig/TestCases/Output/create_thread_leak.cpp.tmp 10 1 0 0 2>&1 | FileCheck /home/b/sanitizer-aarch64-linux/build/llvm-project/compiler-rt/test/lsan/TestCases/create_thread_leak.cpp --check-prefixes=LEAK,LEAK123
> # executed command: not /home/b/sanitizer-aarch64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/test/lsan/AARCH64HWAsanConfig/TestCases/Output/create_thread_leak.cpp.tmp 10 1 0 0
> # note: command had no output on stdout or stderr
> # executed command: FileCheck /home/b/sanitizer-aarch64-linux/build/llvm-project/compiler-rt/test/lsan/TestCases/create_thread_leak.cpp --check-prefixes=LEAK,LEAK123
> # note: command had no output on stdout or stderr
> # RUN: at line 5
> not  /home/b/sanitizer-aarch64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/test/lsan/AARCH64HWAsanConfig/TestCases/Output/create_thread_leak.cpp.tmp 10 0 1 0 2>&1 | FileCheck /home/b/sanitizer-aarch64-linux/build/llvm-project/compiler-rt/test/lsan/TestCases/create_thread_leak.cpp --check-prefixes=LEAK,LEAK234
> # executed command: not /home/b/sanitizer-aarch64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/test/lsan/AARCH64HWAsanConfig/TestCases/Output/create_thread_leak.cpp.tmp 10 0 1 0
> # note: command had no output on stdout or stderr
> # executed command: FileCheck /home/b/sanitizer-aarch64-linux/build/llvm-project/compiler-rt/test/lsan/TestCases/create_thread_leak.cpp --check-prefixes=LEAK,LEAK234
> # note: command had no output on stdout or stderr
> # RUN: at line 6
> not  /home/b/sanitizer-aarch64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/test/lsan/AARCH64HWAsanConfig/TestCases/Output/create_thread_leak.cpp.tmp 10 0 0 1 2>&1 | FileCheck /home/b/sanitizer-aarch64-linux/build/llvm-project/compiler-rt/test/lsan/TestCases/create_thread_leak.cpp --check-prefixes=LEAK,LEAK234
> # executed command: not /home/b/sanitizer-aarch64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/test/lsan/AARCH64HWAsanConfig/TestCases/Output/create_thread_leak.cpp.tmp 10 0 0 1
> # note: command had no output on stdout or stderr
> # error: command failed with exit status: 1
> # executed command: FileCheck /home/b/sanitizer-aarch64-linux/build/llvm-project/compiler-rt/test/lsan/TestCases/create_thread_leak.cpp --check-prefixes=LEAK,LEAK234
> # .---command stderr------------
> # | FileCheck error: '<stdin>' is empty.
> # | FileCheck command line:  FileCheck /home/b/sanitizer-aarch64-linux/build/llvm-project/compiler-rt/test/lsan/TestCases/create_thread_leak.cpp --check-prefixes=LEAK,LEAK234
> # `-----------------------------
> # error: command failed with exit status: 2
> 
> --
> 
> ********************
> Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
> ```

i think this is unrelated to this patch ... or is it because of this patch ? @thurstond really sorry for pinging again i never saw something like this would be really grateful if you can conform thanks

https://github.com/llvm/llvm-project/pull/218494