[llvm] [orc-rt] Remove redundant extern keyword. (PR #222619)

Lang Hames via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 10 04:59:13 PDT 2026


https://github.com/lhames updated https://github.com/llvm/llvm-project/pull/222619

>From a736b3212e707674cd68049df97010a54ea2e400 Mon Sep 17 00:00:00 2001
From: Lang Hames <lhames at apple.com>
Date: Thu, 10 Sep 2026 21:50:26 +1000
Subject: [PATCH 1/2] [orc-rt] Remove redundant extern keyword.

orc_rt_log_OSLogHandles is already extern via ORC_RT_C_EXPORT.
---
 orc-rt/include/orc-rt-c/support/Logging.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/orc-rt/include/orc-rt-c/support/Logging.h b/orc-rt/include/orc-rt-c/support/Logging.h
index 85f704470ec24..4e2a0983dcdfa 100644
--- a/orc-rt/include/orc-rt-c/support/Logging.h
+++ b/orc-rt/include/orc-rt-c/support/Logging.h
@@ -234,7 +234,7 @@ ORC_RT_C_EXPORT void orc_rt_log_printf(orc_rt_log_Level Level,
  * are filled lazily (and read) atomically by orc_rt_log_osLogHandle. An
  * implementation detail of that accessor; do not use directly.
  */
-ORC_RT_C_EXPORT extern os_log_t
+ORC_RT_C_EXPORT os_log_t
     orc_rt_log_OSLogHandles[orc_rt_log_Category_Count];
 
 /*

>From f92f13fc48d2601724728111566065c9cf296ac9 Mon Sep 17 00:00:00 2001
From: Lang Hames <lhames at apple.com>
Date: Thu, 10 Sep 2026 21:58:53 +1000
Subject: [PATCH 2/2] clang-format

---
 orc-rt/include/orc-rt-c/support/Logging.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/orc-rt/include/orc-rt-c/support/Logging.h b/orc-rt/include/orc-rt-c/support/Logging.h
index 4e2a0983dcdfa..a52ffe635187b 100644
--- a/orc-rt/include/orc-rt-c/support/Logging.h
+++ b/orc-rt/include/orc-rt-c/support/Logging.h
@@ -234,8 +234,7 @@ ORC_RT_C_EXPORT void orc_rt_log_printf(orc_rt_log_Level Level,
  * are filled lazily (and read) atomically by orc_rt_log_osLogHandle. An
  * implementation detail of that accessor; do not use directly.
  */
-ORC_RT_C_EXPORT os_log_t
-    orc_rt_log_OSLogHandles[orc_rt_log_Category_Count];
+ORC_RT_C_EXPORT os_log_t orc_rt_log_OSLogHandles[orc_rt_log_Category_Count];
 
 /*
  * Cold path for orc_rt_log_osLogHandle: creates the handle for Category (in the



More information about the llvm-commits mailing list