[llvm] ddf2077 - [GlobalISel] Fix duplicate finalizeLowering calls (NFC) (#221902)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 9 00:52:14 PDT 2026
Author: Cullen Rhodes
Date: 2026-09-09T08:52:09+01:00
New Revision: ddf2077559587500f47e3666c696b7366bb36af0
URL: https://github.com/llvm/llvm-project/commit/ddf2077559587500f47e3666c696b7366bb36af0
DIFF: https://github.com/llvm/llvm-project/commit/ddf2077559587500f47e3666c696b7366bb36af0.diff
LOG: [GlobalISel] Fix duplicate finalizeLowering calls (NFC) (#221902)
Improves CTMark geomean -0.07% on aarch64-O0-g.
https://llvm-compile-time-tracker.com/compare.php?from=97cbc1e404b980edc58bfbcabb6f1c61793b624b&to=d8b1a78ba013d5e687acc0e8bf00d3d77749f3db&stat=instructions:u
Assisted-by: codex
Added:
Modified:
llvm/lib/CodeGen/FinalizeISel.cpp
llvm/lib/CodeGen/GlobalISel/InstructionSelect.cpp
llvm/lib/Target/SPIRV/SPIRVISelLowering.cpp
Removed:
################################################################################
diff --git a/llvm/lib/CodeGen/FinalizeISel.cpp b/llvm/lib/CodeGen/FinalizeISel.cpp
index 7069a8862b7df..da2936bdd4b11 100644
--- a/llvm/lib/CodeGen/FinalizeISel.cpp
+++ b/llvm/lib/CodeGen/FinalizeISel.cpp
@@ -47,7 +47,9 @@ static std::pair<bool, bool> runImpl(MachineFunction &MF) {
const TargetInstrInfo *TII = MF.getSubtarget().getInstrInfo();
const TargetLowering *TLI = MF.getSubtarget().getTargetLowering();
- TLI->finalizeLowering(MF);
+ // GlobalISel finalizes lowering in InstructionSelect.
+ if (!MF.getProperties().hasSelected())
+ TLI->finalizeLowering(MF);
// Iterate through each instruction in the function, looking for pseudos.
for (MachineFunction::iterator I = MF.begin(), E = MF.end(); I != E; ++I) {
diff --git a/llvm/lib/CodeGen/GlobalISel/InstructionSelect.cpp b/llvm/lib/CodeGen/GlobalISel/InstructionSelect.cpp
index ccb1828ba3f96..c4baeb75597a6 100644
--- a/llvm/lib/CodeGen/GlobalISel/InstructionSelect.cpp
+++ b/llvm/lib/CodeGen/GlobalISel/InstructionSelect.cpp
@@ -342,7 +342,6 @@ bool InstructionSelectImpl::selectMachineFunction(MachineFunction &MF) {
}
}
- // FIXME: FinalizeISel pass calls finalizeLowering, so it's called twice.
auto &TLI = *MF.getSubtarget().getTargetLowering();
TLI.finalizeLowering(MF);
diff --git a/llvm/lib/Target/SPIRV/SPIRVISelLowering.cpp b/llvm/lib/Target/SPIRV/SPIRVISelLowering.cpp
index 805acfdec37b9..896dc4abb6891 100644
--- a/llvm/lib/Target/SPIRV/SPIRVISelLowering.cpp
+++ b/llvm/lib/Target/SPIRV/SPIRVISelLowering.cpp
@@ -523,8 +523,6 @@ static void validateVec1Ops(const SPIRVSubtarget &STI, MachineRegisterInfo *MRI,
// TODO: the logic of inserting additional bitcast's is to be moved
// to pre-IRTranslation passes eventually
void SPIRVTargetLowering::finalizeLowering(MachineFunction &MF) const {
- // finalizeLowering() is called twice (see GlobalISel/InstructionSelect.cpp)
- // We'd like to avoid the needless second processing pass.
if (MF.getRegInfo().reservedRegsFrozen())
return;
More information about the llvm-commits
mailing list