[llvm] [Support][FileSystem] Prefer `status` with `file_t` parameter. NFC. (PR #157581)

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 8 21:52:47 PDT 2026


https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/157581

>From 62554e863ed3a0ef5cefd383c4343605c5bc9385 Mon Sep 17 00:00:00 2001
From: Steven Wu <stevenwu at apple.com>
Date: Mon, 8 Sep 2025 17:18:24 -0700
Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
 =?UTF-8?q?itial=20version?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Created using spr 1.3.6
---
 llvm/include/llvm/Support/FileSystem.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/llvm/include/llvm/Support/FileSystem.h b/llvm/include/llvm/Support/FileSystem.h
index 1f66bca37db94..d33f90956520b 100644
--- a/llvm/include/llvm/Support/FileSystem.h
+++ b/llvm/include/llvm/Support/FileSystem.h
@@ -655,12 +655,12 @@ LLVM_ABI std::error_code is_other(const Twine &path, bool &result);
 LLVM_ABI std::error_code status(const Twine &path, file_status &result,
                                 bool follow = true);
 
-/// A version for when a file descriptor is already available.
-LLVM_ABI std::error_code status(int FD, file_status &Result);
+/// A version for when a file handle is already available.
+LLVM_ABI std::error_code status(file_t FD, file_status &Result);
 
 #ifdef _WIN32
 /// A version for when a file descriptor is already available.
-LLVM_ABI std::error_code status(file_t FD, file_status &Result);
+LLVM_ABI std::error_code status(int FD, file_status &Result);
 #endif
 
 /// Get file creation mode mask of the process.

>From 76aa2186f0607bb3fa024fdb0daad63bcd90dfe3 Mon Sep 17 00:00:00 2001
From: Steven Wu <stevenwu at apple.com>
Date: Mon, 8 Sep 2025 17:26:17 -0700
Subject: [PATCH 2/2] rename parameter

Created using spr 1.3.6
---
 llvm/include/llvm/Support/FileSystem.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/include/llvm/Support/FileSystem.h b/llvm/include/llvm/Support/FileSystem.h
index d33f90956520b..d8ebca97f2a62 100644
--- a/llvm/include/llvm/Support/FileSystem.h
+++ b/llvm/include/llvm/Support/FileSystem.h
@@ -656,7 +656,7 @@ LLVM_ABI std::error_code status(const Twine &path, file_status &result,
                                 bool follow = true);
 
 /// A version for when a file handle is already available.
-LLVM_ABI std::error_code status(file_t FD, file_status &Result);
+LLVM_ABI std::error_code status(file_t F, file_status &Result);
 
 #ifdef _WIN32
 /// A version for when a file descriptor is already available.



More information about the llvm-commits mailing list