[llvm] [libsycl] Implement fill & memset queue API (PR #217933)
Dmitry Rogozhkin via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 8 12:58:19 PDT 2026
dvrogozh wrote:
>> please, add PR description.
>
> I'm not sure what information would be there other than just restating the commit summary. What do you think is missing?
You can add details to the PR description on what is and what is not implemented in respect to the API's you are adding in this PR. For example, in one of the comments you state that "we're missing one overload for fill according to [rev 12](https://registry.khronos.org/SYCL/specs/sycl-2020/html/sycl-2020.html#api:queue-fill). I assume we don't have necessary dependencies yet as that's why it was omitted". Consider that PR description ends up as a squashed commit message reading which should give the reader understanding of the state being introduced by the commit without reviewing commit body itself.
https://github.com/llvm/llvm-project/pull/217933
More information about the llvm-commits
mailing list