[llvm] [VPlan] Simplify PlainCFG VPI construction (NFC) (PR #216435)

[Andrei Elovikov via llvm-commits]

================
@@ -395,13 +401,6 @@ class VPBuilder {
         new VPDerivedIVRecipe(Kind, FPBinOp, Start, Current, Step, Flags));
   }
 
-  VPInstructionWithType *createScalarLoad(Type *ResultTy, VPValue *Addr,
-                                          DebugLoc DL,
-                                          const VPIRMetadata &Metadata = {}) {
-    return tryInsertInstruction(new VPInstructionWithType(
----------------
eas wrote:

I'm not sure if that's correct because of the `classof` implementation for `VPInstructionWithType`, However, we should just drop `VPInstructionWithType` completely - created https://github.com/llvm/llvm-project/pull/222103.

https://github.com/llvm/llvm-project/pull/216435