[llvm] [llvm-strings] Add --encoding & --unicode options (PR #221794)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 8 00:00:43 PDT 2026


https://github.com/jh7370 commented:

As this is a big change, it'll take a bit of time for me to fully review it. In the meantime, some quick high-level things:

1) Please update the GNU strings command guide with the new options.
2) I'd have expected to see new test files that are dedicated to the behaviour of the new options. It's often easier to reason with them when they have their own specific testing, rather than folding in with other test cases.
3) Please include a link to the RFC discussion in the PR description.

https://github.com/llvm/llvm-project/pull/221794


More information about the llvm-commits mailing list