[llvm] [VPlan] Simplify PlainCFG VPI construction (NFC) (PR #216435)

[Ramkumar Ramachandra via llvm-commits]

================
@@ -395,13 +401,6 @@ class VPBuilder {
         new VPDerivedIVRecipe(Kind, FPBinOp, Start, Current, Step, Flags));
   }
 
-  VPInstructionWithType *createScalarLoad(Type *ResultTy, VPValue *Addr,
-                                          DebugLoc DL,
-                                          const VPIRMetadata &Metadata = {}) {
-    return tryInsertInstruction(new VPInstructionWithType(
----------------
artagnon wrote:

Hm, VPInstruction and VPInstructionWithType should be equivalent when the ResultTy is passed? VPInstructionWithType simply inherits from VPInstruction and duplicates the return type (or the "scalar type") in a private member? Wrote a quick PR description.

https://github.com/llvm/llvm-project/pull/216435