[llvm] b1f20dd - [TableGen] Escape single quotes when emitting a string table as char literals (#221612)

via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 6 15:42:15 PDT 2026


Author: Fangrui Song
Date: 2026-09-06T15:42:10-07:00
New Revision: b1f20dd48e11439d5a592662b407e07d8213ffee

URL: https://github.com/llvm/llvm-project/commit/b1f20dd48e11439d5a592662b407e07d8213ffee
DIFF: https://github.com/llvm/llvm-project/commit/b1f20dd48e11439d5a592662b407e07d8213ffee.diff

LOG: [TableGen] Escape single quotes when emitting a string table as char literals (#221612)

Fix a latent bug in StringToOffsetTable, which led to breakage after
#218845

```
C:\_work\llvm-project\llvm-project\build\tools\clang\include\clang/Options/Options.inc(135,18): error: expected expression
C:\_work\llvm-project\llvm-project\build\tools\clang\include\clang/Options/Options.inc(135,24): warning: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
  135 |   'D', 'o', 'n', ''', 't', ' ', 'e', 'm', 'i', 't', ' ', 'e', 'r', 'r', 'o', 'r', 's', ' ', 'o', 'n', ' ', 'i', 'n', 'v', 'a', 'l', 'i', 'd', ' ', 'a', 'n', 'a', 'l', 'y', 'z', 'e', 'r', '-', 'c', 'o', 'n', 'f', 'i', 'g', ' ', 'i', 'n', 'p', 'u', 't', 's', '\0',
      |                        ^
```

Added: 
    

Modified: 
    llvm/lib/TableGen/StringToOffsetTable.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/TableGen/StringToOffsetTable.cpp b/llvm/lib/TableGen/StringToOffsetTable.cpp
index 546a11ac1287f..0be309e622f12 100644
--- a/llvm/lib/TableGen/StringToOffsetTable.cpp
+++ b/llvm/lib/TableGen/StringToOffsetTable.cpp
@@ -72,7 +72,10 @@ void StringToOffsetTable::EmitStringTableDef(raw_ostream &OS,
     ListSeparator CharSep(", ");
     for (char C : Str) {
       OS << CharSep << "'";
-      OS.write_escaped(StringRef(&C, 1));
+      if (C == '\'')
+        OS << "\\'";
+      else
+        OS.write_escaped(StringRef(&C, 1));
       OS << "'";
     }
     OS << CharSep << "'\\0'";


        


More information about the llvm-commits mailing list