[clang] [llvm] DAGCombiner: Drop AllowFPOpFusion from visitFADDForFMACombine (PR #221436)

[LLVM Continuous Integration via llvm-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `clang-aarch64-sve2-vla` running on `linaro-g4-01` while building `clang,llvm` at step 7 "ninja check 1".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/198/builds/15108

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 7 (ninja check 1) failure: stage 1 checked (failure)
******************** TEST 'LLVM :: CodeGen/ARM/fp16-instructions.ll' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 2
/home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/llc < /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/llvm/test/CodeGen/ARM/fp16-instructions.ll -mtriple=arm-none-eabi -float-abi=soft     | /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/FileCheck /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFT
# executed command: /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/llc -mtriple=arm-none-eabi -float-abi=soft
# executed command: /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/FileCheck /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFT
# RUN: at line 3
/home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/llc < /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/llvm/test/CodeGen/ARM/fp16-instructions.ll -mtriple=thumb-none-eabi -float-abi=soft   | /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/FileCheck /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFT
# executed command: /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/llc -mtriple=thumb-none-eabi -float-abi=soft
# executed command: /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/FileCheck /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFT
# RUN: at line 4
/home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/llc < /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/llvm/test/CodeGen/ARM/fp16-instructions.ll -mtriple=thumbv8.1m.main-none-eabi -mattr=+mve | /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/FileCheck /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFT
# executed command: /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/llc -mtriple=thumbv8.1m.main-none-eabi -mattr=+mve
# executed command: /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/FileCheck /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFT
# RUN: at line 5
/home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/llc < /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/llvm/test/CodeGen/ARM/fp16-instructions.ll -mtriple=thumbv8.1m.main-none-eabi -float-abi=soft -mattr=+mve | /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/FileCheck /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFT
# executed command: /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/llc -mtriple=thumbv8.1m.main-none-eabi -float-abi=soft -mattr=+mve
# executed command: /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/FileCheck /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFT
# RUN: at line 8
/home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/llc < /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/llvm/test/CodeGen/ARM/fp16-instructions.ll -mtriple=arm-none-eabi -mattr=+vfp3        | /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/FileCheck /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFTFP-VFP3
# executed command: /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/llc -mtriple=arm-none-eabi -mattr=+vfp3
# executed command: /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/FileCheck /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFTFP-VFP3
# RUN: at line 9
/home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/llc < /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/llvm/test/CodeGen/ARM/fp16-instructions.ll -mtriple=arm-none-eabi -mattr=+vfp4        | /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/FileCheck /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFTFP-FP16,CHECK-SOFTFP-FP16-A32
# executed command: /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/llc -mtriple=arm-none-eabi -mattr=+vfp4
# executed command: /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/FileCheck /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFTFP-FP16,CHECK-SOFTFP-FP16-A32
# RUN: at line 10
/home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/llc < /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/llvm/test/CodeGen/ARM/fp16-instructions.ll -mtriple=arm-none-eabi -mattr=+fullfp16,+fp64    | /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/FileCheck /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFTFP-FULLFP16
# executed command: /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/llc -mtriple=arm-none-eabi -mattr=+fullfp16,+fp64
# executed command: /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/FileCheck /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFTFP-FULLFP16
# RUN: at line 12
/home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/llc < /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/llvm/test/CodeGen/ARM/fp16-instructions.ll -mtriple=thumbv7-none-eabi -mattr=+vfp3        | /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/FileCheck /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFTFP-VFP3
# executed command: /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/llc -mtriple=thumbv7-none-eabi -mattr=+vfp3
# executed command: /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/FileCheck /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFTFP-VFP3
# RUN: at line 13
/home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/llc < /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/llvm/test/CodeGen/ARM/fp16-instructions.ll -mtriple=thumbv7-none-eabi -mattr=+vfp4        | /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/FileCheck /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFTFP-FP16,CHECK-SOFTFP-FP16-T32
# executed command: /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/llc -mtriple=thumbv7-none-eabi -mattr=+vfp4
# executed command: /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/FileCheck /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFTFP-FP16,CHECK-SOFTFP-FP16-T32
# RUN: at line 14
/home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/llc < /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/llvm/test/CodeGen/ARM/fp16-instructions.ll -mtriple=thumbv7-none-eabi -mattr=+fullfp16,+fp64    | /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/FileCheck /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFTFP-FULLFP16
# executed command: /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/llc -mtriple=thumbv7-none-eabi -mattr=+fullfp16,+fp64
# executed command: /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/FileCheck /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFTFP-FULLFP16
# RUN: at line 17
/home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/llc < /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/llvm/test/CodeGen/ARM/fp16-instructions.ll -mtriple=arm-none-eabi -mattr=+fullfp16,+fp64 -O0 | /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/FileCheck /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK-SPILL-RELOAD
# executed command: /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/llc -mtriple=arm-none-eabi -mattr=+fullfp16,+fp64 -O0
# executed command: /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/stage1/bin/FileCheck /home/tcwg-buildbot/worker/clang-aarch64-sve2-vla/llvm/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK-SPILL-RELOAD
# RUN: at line 18
...

```

</details>

https://github.com/llvm/llvm-project/pull/221436