[lld] [lld-macho][NFC] Change _baz to _qux in test (PR #220337)
via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 1 11:53:59 PDT 2026
llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-lld-macho
Author: Keith Smiley (keith)
<details>
<summary>Changes</summary>
These assertions are very broad and when running these tests in bazel
there is a file path log that gets incorrectly matched with _baz.
---
Full diff: https://github.com/llvm/llvm-project/pull/220337.diff
1 Files Affected:
- (modified) lld/test/MachO/U-dynamic-lookup.s (+4-4)
``````````diff
diff --git a/lld/test/MachO/U-dynamic-lookup.s b/lld/test/MachO/U-dynamic-lookup.s
index b0b4f7734a3e3..7dcb16bb857c7 100644
--- a/lld/test/MachO/U-dynamic-lookup.s
+++ b/lld/test/MachO/U-dynamic-lookup.s
@@ -8,15 +8,15 @@
# _foo starts out as a (non-weak) dynamically looked up symbol and is merged
# against the Undefined from foo.o. _bar isn't referenced in any object file,
-# but starts out as Undefined because of the -u flag. _baz isn't referenced
+# but starts out as Undefined because of the -u flag. _qux isn't referenced
# at all.
-# RUN: %lld -lSystem %t/main.o -U _foo -U _bar -u _bar -U _baz -o %t/out
+# RUN: %lld -lSystem %t/main.o -U _foo -U _bar -u _bar -U _qux -o %t/out
# RUN: llvm-objdump --macho --lazy-bind %t/out | FileCheck --check-prefix=DYNAMIC %s
# RUN: llvm-nm -m %t/out | FileCheck --check-prefix=DYNAMICSYM %s
# Same thing should happen if _foo starts out as an Undefined.
# `-U _foo` being passed twice shouldn't have an effect either.
-# RUN: %lld -lSystem %t/main.o -u _foo -U _foo -U _foo -u _bar -U _bar -U _baz -o %t/out
+# RUN: %lld -lSystem %t/main.o -u _foo -U _foo -U _foo -u _bar -U _bar -U _qux -o %t/out
# RUN: llvm-objdump --macho --lazy-bind %t/out | FileCheck --check-prefix=DYNAMIC %s
# RUN: llvm-nm -m %t/out | FileCheck --check-prefix=DYNAMICSYM %s
@@ -26,7 +26,7 @@
# handles this case, so match ld64's behavior.
# DYNAMIC-NOT: _bar
-# DYNAMIC-NOT: _baz
+# DYNAMIC-NOT: _qux
# DYNAMIC: flat-namespace _foo
# DYNAMICSYM: (undefined) external _bar (dynamically looked up)
``````````
</details>
https://github.com/llvm/llvm-project/pull/220337
More information about the llvm-commits
mailing list