[llvm] [AMDGPU][GFX12/GFX13] Add cdbg branch support and lower llvm.is.debugging.enabled (PR #219178)
via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 28 01:10:20 PDT 2026
Alexander =?utf-8?q?Hück?= <alexander.huck at amd.com>,
Alexander =?utf-8?q?Hück?= <alexander.huck at amd.com>,
Alexander =?utf-8?q?Hück?= <alexander.huck at amd.com>,
Alexander =?utf-8?q?Hück?= <alexander.huck at amd.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/219178 at github.com>
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,h -- llvm/include/llvm/Target/TargetMachine.h llvm/lib/CodeGen/PreISelIntrinsicLowering.cpp llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp llvm/lib/Target/AMDGPU/AMDGPULowerIntrinsics.cpp llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.h llvm/lib/Target/AMDGPU/SIISelLowering.cpp llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/llvm/include/llvm/Target/TargetMachine.h b/llvm/include/llvm/Target/TargetMachine.h
index ea26be5e4..4e8125d34 100644
--- a/llvm/include/llvm/Target/TargetMachine.h
+++ b/llvm/include/llvm/Target/TargetMachine.h
@@ -569,10 +569,10 @@ public:
virtual bool canLowerCondLoop() const { return false; }
/// Returns whether this target takes responsibility for lowering
- /// llvm.is.debugging.enabled. If false, generic lowering replaces the intrinsic
- /// with false. If true, the target must handle every supported subtarget,
- /// including replacing the intrinsic with false on subtargets without native
- /// lowering.
+ /// llvm.is.debugging.enabled. If false, generic lowering replaces the
+ /// intrinsic with false. If true, the target must handle every supported
+ /// subtarget, including replacing the intrinsic with false on subtargets
+ /// without native lowering.
virtual bool canLowerIsDebuggingEnabled() const { return false; }
};
diff --git a/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp b/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
index c42060e69..64f213b3f 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
@@ -4873,8 +4873,8 @@ matchCFIntrinsicBranchUse(MachineInstr &MI, MachineRegisterInfo &MRI) {
MachineBasicBlock *TakenTarget = UseMI->getOperand(1).getMBB();
return CFIntrinsicBranchMatch{Negation, UseMI, UncondBr,
- Negation ? OtherTarget : TakenTarget,
- Negation ? TakenTarget : OtherTarget};
+ Negation ? OtherTarget : TakenTarget,
+ Negation ? TakenTarget : OtherTarget};
}
void AMDGPULegalizerInfo::buildLoadInputValue(Register DstReg,
``````````
</details>
https://github.com/llvm/llvm-project/pull/219178
More information about the llvm-commits
mailing list