[llvm] select the greater symbol to display (PR #219382)

[via llvm-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-llvm-binary-utilities

Author: cherryscake

<details>
<summary>Changes</summary>

when multiple symbols share the same address,prefer a non-NOTYPE symbol (e.g. STT_FUNC) as the display label.

---
Full diff: https://github.com/llvm/llvm-project/pull/219382.diff


1 Files Affected:

- (modified) llvm/tools/llvm-objdump/llvm-objdump.cpp (+3-1) 


``````````diff
diff --git a/llvm/tools/llvm-objdump/llvm-objdump.cpp b/llvm/tools/llvm-objdump/llvm-objdump.cpp
index 92c1c2da3d025..a2e53d445aaf5 100644
--- a/llvm/tools/llvm-objdump/llvm-objdump.cpp
+++ b/llvm/tools/llvm-objdump/llvm-objdump.cpp
@@ -2251,7 +2251,9 @@ disassembleObject(ObjectFile &Obj, const ObjectFile &DbgObj,
           uint8_t SymTy = SymbolsHere[i].Type;
           if (SymTy != ELF::STT_OBJECT && SymTy != ELF::STT_COMMON) {
             DisassembleAsELFData = false;
-            DisplaySymIndex = i;
+            if(SymTy != ELF::STT_NOTYPE || SymbolsHere[DisplaySymIndex].Type == ELF::STT_NOTYPE) {
+              DisplaySymIndex = i;
+            }
           }
         }
       }

``````````

</details>


https://github.com/llvm/llvm-project/pull/219382