[llvm] workflow/release-binaries: Hard-code Wix install path (PR #219328)

Tom Stellard via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 27 21:31:58 PDT 2026


https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/219328

>From 6a6e3cc0e89294ffb55044f246caad5de2d202cd Mon Sep 17 00:00:00 2001
From: Tom Stellard <tstellar at redhat.com>
Date: Thu, 27 Aug 2026 16:40:06 -0700
Subject: [PATCH 1/3] workflow/release-binaries: Hard-code Wix install path

Searching for the candle.exe executable is very slow and we know the
install path will always be the same since we have version pinned the
install.
---
 .github/workflows/release-binaries.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/release-binaries.yml b/.github/workflows/release-binaries.yml
index d837461b24643..707a2c8926e2c 100644
--- a/.github/workflows/release-binaries.yml
+++ b/.github/workflows/release-binaries.yml
@@ -287,7 +287,7 @@ jobs:
       run: |
         choco install wixtoolset --version 3.14.1.20250415
         # Add wix install directory to PATH.
-        Split-Path (Get-ChildItem -Path "C:\" -Filter candle.exe -Recurse -ErrorAction SilentlyContinue | Select-Object -First 1).FullName >> $env:GITHUB_PATH
+        echo "C:\Program Files (x86)\WiX Toolset v3.14\bin" >> $env:GITHUB_PATH
 
     - name: Build Windows
       id: build-windows

>From 4e42f989e6cb9f7e1902692b1dad7b28a618b65d Mon Sep 17 00:00:00 2001
From: Tom Stellard <tstellar at redhat.com>
Date: Thu, 27 Aug 2026 20:47:23 -0700
Subject: [PATCH 2/3] Add environment variable

---
 .github/workflows/release-binaries.yml | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/release-binaries.yml b/.github/workflows/release-binaries.yml
index 707a2c8926e2c..4bceb37ad822b 100644
--- a/.github/workflows/release-binaries.yml
+++ b/.github/workflows/release-binaries.yml
@@ -283,11 +283,13 @@ jobs:
 
     # Wix is not installed by default on Windows ARM64
     - name: Install Wix (Windows ARM64)
+      env:
+        WIX_VERSION: 3.14
       if: runner.os == 'Windows' && runner.arch == 'ARM64'
       run: |
-        choco install wixtoolset --version 3.14.1.20250415
+        choco install wixtoolset --version $env:WIX_VERSION.1.20250415
         # Add wix install directory to PATH.
-        echo "C:\Program Files (x86)\WiX Toolset v3.14\bin" >> $env:GITHUB_PATH
+        echo "C:\Program Files (x86)\WiX Toolset v$env:WIX_VERSION\bin" >> $env:GITHUB_PATH
 
     - name: Build Windows
       id: build-windows

>From d093f7db9e45d3ca09351ae142db44ec390df2f0 Mon Sep 17 00:00:00 2001
From: Tom Stellard <tstellar at redhat.com>
Date: Thu, 27 Aug 2026 21:31:38 -0700
Subject: [PATCH 3/3] Fix

---
 .github/workflows/release-binaries.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/release-binaries.yml b/.github/workflows/release-binaries.yml
index 4bceb37ad822b..e768ab0713393 100644
--- a/.github/workflows/release-binaries.yml
+++ b/.github/workflows/release-binaries.yml
@@ -287,9 +287,9 @@ jobs:
         WIX_VERSION: 3.14
       if: runner.os == 'Windows' && runner.arch == 'ARM64'
       run: |
-        choco install wixtoolset --version $env:WIX_VERSION.1.20250415
+        choco install wixtoolset --version $($env:WIX_VERSION).1.20250415
         # Add wix install directory to PATH.
-        echo "C:\Program Files (x86)\WiX Toolset v$env:WIX_VERSION\bin" >> $env:GITHUB_PATH
+        echo "C:\Program Files (x86)\WiX Toolset v$($env:WIX_VERSION\bin)" >> $env:GITHUB_PATH
 
     - name: Build Windows
       id: build-windows



More information about the llvm-commits mailing list