[llvm] [MCParser][NFCI] Deduplicate isIdentifierChar. (#218100) (PR #218851)

via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 27 00:53:20 PDT 2026


================
@@ -130,6 +131,17 @@ class AsmLexer {
     return Tok;
   }
 
+  /// LexIdentifier: [a-zA-Z_$.@?][a-zA-Z0-9_$.@#?]*
----------------
zhangweize9-cyber wrote:

That’s a good point! However, after giving it some further thought, I realized my proposal still has some shortcomings. So, I plan to move forward with MaskRay’s proposal (i.e., #219084) and close my own for now; we can discuss it later depending on how things go.

https://github.com/llvm/llvm-project/pull/218851


More information about the llvm-commits mailing list