[llvm] [llvm-readobj] Resolve relocations to function symbols and addends in call-graph-info (PR #213156)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 26 02:07:16 PDT 2026


================

----------------
jh7370 wrote:

As a general rule, `consumeError` is usually a mistake. At the very least it should be commented saying why it's okay to ignore the error in this case. More likely, a warning should be printed. If no error could ever actually be hit here because the same error would always be triggered earlier, the correct thing to do is `cantFail`.

https://github.com/llvm/llvm-project/pull/213156


More information about the llvm-commits mailing list