[llvm] [NFC] Remove default CostKind from multiple TTI functions (PR #218547)
Ryan Buchner via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 24 15:54:59 PDT 2026
https://github.com/bababuck created https://github.com/llvm/llvm-project/pull/218547
Grouped these together since they require no parameter reordering and the default `CostKind`s were never used.
Addresses #135598.
>From 012098fa4a0b24720f43585cfd3a19615e7349ca Mon Sep 17 00:00:00 2001
From: bababuck <buchner.ryan at gmail.com>
Date: Mon, 24 Aug 2026 14:15:07 -0700
Subject: [PATCH] [NFC] Remove default CostKind from multiple TTI functions
Threw these altogether since they require no paramter reordering
and the default CostKinds were never used.
---
.../llvm/Analysis/TargetTransformInfo.h | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/llvm/include/llvm/Analysis/TargetTransformInfo.h b/llvm/include/llvm/Analysis/TargetTransformInfo.h
index 1a191716ed1ad..dda5c37727d06 100644
--- a/llvm/include/llvm/Analysis/TargetTransformInfo.h
+++ b/llvm/include/llvm/Analysis/TargetTransformInfo.h
@@ -1553,7 +1553,7 @@ class TargetTransformInfo {
LLVM_ABI InstructionCost getAltInstrCost(
VectorType *VecTy, unsigned Opcode0, unsigned Opcode1,
const SmallBitVector &OpcodeMask,
- TTI::TargetCostKind CostKind = TTI::TCK_RecipThroughput) const;
+ TTI::TargetCostKind CostKind) const;
/// \return The cost of a shuffle instruction of kind Kind with inputs of type
/// SrcTy, producing a vector of type DstTy. The exact mask may be passed as
@@ -1609,7 +1609,7 @@ class TargetTransformInfo {
/// may be passed in the 'I' parameter.
LLVM_ABI InstructionCost getCastInstrCost(
unsigned Opcode, Type *Dst, Type *Src, TTI::CastContextHint CCH,
- TTI::TargetCostKind CostKind = TTI::TCK_SizeAndLatency,
+ TTI::TargetCostKind CostKind,
const Instruction *I = nullptr) const;
/// \return The expected cost of a sign- or zero-extended vector extract. Use
@@ -1621,7 +1621,7 @@ class TargetTransformInfo {
/// \return The expected cost of control-flow related instructions such as
/// Phi, Ret, Br, Switch.
LLVM_ABI InstructionCost getCFInstrCost(
- unsigned Opcode, TTI::TargetCostKind CostKind = TTI::TCK_SizeAndLatency,
+ unsigned Opcode, TTI::TargetCostKind CostKind,
const Instruction *I = nullptr) const;
/// \returns The expected cost of compare and select instructions. If there
@@ -1633,7 +1633,7 @@ class TargetTransformInfo {
/// two operands are the *value* operands, not the condition operand.
LLVM_ABI InstructionCost getCmpSelInstrCost(
unsigned Opcode, Type *ValTy, Type *CondTy, CmpInst::Predicate VecPred,
- TTI::TargetCostKind CostKind = TTI::TCK_RecipThroughput,
+ TTI::TargetCostKind CostKind,
OperandValueInfo Op1Info = {OK_AnyValue, OP_None},
OperandValueInfo Op2Info = {OK_AnyValue, OP_None},
const Instruction *I = nullptr) const;
@@ -1720,7 +1720,7 @@ class TargetTransformInfo {
LLVM_ABI InstructionCost getInterleavedMemoryOpCost(
unsigned Opcode, Type *VecTy, unsigned Factor, ArrayRef<unsigned> Indices,
Align Alignment, unsigned AddressSpace,
- TTI::TargetCostKind CostKind = TTI::TCK_RecipThroughput,
+ TTI::TargetCostKind CostKind,
bool UseMaskForCond = false, bool UseMaskForGaps = false) const;
/// A helper function to determine the type of reduction algorithm used
@@ -1755,7 +1755,7 @@ class TargetTransformInfo {
///
LLVM_ABI InstructionCost getArithmeticReductionCost(
unsigned Opcode, VectorType *Ty, std::optional<FastMathFlags> FMF,
- TTI::TargetCostKind CostKind = TTI::TCK_RecipThroughput) const;
+ TTI::TargetCostKind CostKind) const;
LLVM_ABI InstructionCost getMinMaxReductionCost(
Intrinsic::ID IID, VectorType *Ty, FastMathFlags FMF = FastMathFlags(),
@@ -1768,7 +1768,7 @@ class TargetTransformInfo {
/// * ResTy vecreduce.add/sub(mul(ext(Ty A), ext(Ty B)).
LLVM_ABI InstructionCost getMulAccReductionCost(
bool IsUnsigned, unsigned RedOpcode, Type *ResTy, VectorType *Ty,
- TTI::TargetCostKind CostKind = TTI::TCK_RecipThroughput) const;
+ TTI::TargetCostKind CostKind) const;
/// Calculate the cost of an extended reduction pattern, similar to
/// getArithmeticReductionCost of a reduction with an extension.
@@ -1777,7 +1777,7 @@ class TargetTransformInfo {
LLVM_ABI InstructionCost getExtendedReductionCost(
unsigned Opcode, bool IsUnsigned, Type *ResTy, VectorType *Ty,
std::optional<FastMathFlags> FMF,
- TTI::TargetCostKind CostKind = TTI::TCK_RecipThroughput) const;
+ TTI::TargetCostKind CostKind) const;
/// \returns The cost of Intrinsic instructions. Analyses the real arguments.
/// Three cases are handled: 1. scalar instruction 2. vector instruction
@@ -1794,7 +1794,7 @@ class TargetTransformInfo {
/// \returns The cost of Call instructions.
LLVM_ABI InstructionCost getCallInstrCost(
Function *F, Type *RetTy, ArrayRef<Type *> Tys,
- TTI::TargetCostKind CostKind = TTI::TCK_SizeAndLatency) const;
+ TTI::TargetCostKind CostKind) const;
/// \returns The number of pieces into which the provided type must be
/// split during legalization. Zero is returned when the answer is unknown.
More information about the llvm-commits
mailing list