[llvm] e3ca61f - AMDGPU: Deprecate getArchAttrAMDGCN (#217769)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 24 06:01:57 PDT 2026
Author: Matt Arsenault
Date: 2026-08-24T15:01:52+02:00
New Revision: e3ca61f7a41d0324453dd4e6fe67d2a4541d810b
URL: https://github.com/llvm/llvm-project/commit/e3ca61f7a41d0324453dd4e6fe67d2a4541d810b
DIFF: https://github.com/llvm/llvm-project/commit/e3ca61f7a41d0324453dd4e6fe67d2a4541d810b.diff
LOG: AMDGPU: Deprecate getArchAttrAMDGCN (#217769)
The legacy ArchFeatureKind bitfield returned by getArchAttrAMDGCN is
being replaced by getFeatureBitset (FEAT_* bits). All in-tree callers have
been migrated, so mark both overloads LLVM_DEPRECATED to steer out of
tree code to the bitset API before the accessor is removed.
Co-authored-by: Claude (Claude-Opus-4.8) <noreply at anthropic.com>
Added:
Modified:
llvm/include/llvm/TargetParser/AMDGPUTargetParser.h
llvm/lib/TargetParser/AMDGPUTargetParser.cpp
Removed:
################################################################################
diff --git a/llvm/include/llvm/TargetParser/AMDGPUTargetParser.h b/llvm/include/llvm/TargetParser/AMDGPUTargetParser.h
index f8e283db55fec..f2c6bdae55c97 100644
--- a/llvm/include/llvm/TargetParser/AMDGPUTargetParser.h
+++ b/llvm/include/llvm/TargetParser/AMDGPUTargetParser.h
@@ -161,7 +161,11 @@ LLVM_ABI StringRef getCanonicalArchName(const Triple &T, StringRef Arch);
LLVM_ABI GPUKind parseArchAMDGCN(StringRef CPU);
LLVM_ABI GPUKind parseArchR600(StringRef CPU);
LLVM_ABI GPUKind getGPUKindFromSubArch(Triple::SubArchType SubArch);
+/// \deprecated Use getFeatureBitset and test the relevant FEAT_* bits instead.
+/// The legacy ArchFeatureKind bitfield is being removed.
+LLVM_DEPRECATED("use getFeatureBitset instead", "getFeatureBitset")
LLVM_ABI unsigned getArchAttrAMDGCN(GPUKind AK);
+LLVM_DEPRECATED("use getFeatureBitset instead", "getFeatureBitset")
LLVM_ABI unsigned getArchAttrAMDGCN(Triple::SubArchType SubArch);
LLVM_ABI R600FeatureKind getArchAttrR600(GPUKind AK);
diff --git a/llvm/lib/TargetParser/AMDGPUTargetParser.cpp b/llvm/lib/TargetParser/AMDGPUTargetParser.cpp
index 98affe3e0d7bd..1f25b579fcc84 100644
--- a/llvm/lib/TargetParser/AMDGPUTargetParser.cpp
+++ b/llvm/lib/TargetParser/AMDGPUTargetParser.cpp
@@ -310,7 +310,8 @@ unsigned AMDGPU::getArchAttrAMDGCN(GPUKind AK) {
}
unsigned AMDGPU::getArchAttrAMDGCN(Triple::SubArchType SubArch) {
- return getArchAttrAMDGCN(getGPUKindFromSubArch(SubArch));
+ const GPUInfo *Info = getAMDGPUInfo(getGPUKindFromSubArch(SubArch));
+ return Info ? Info->ArchFeatures : FEATURE_NONE;
}
R600FeatureKind AMDGPU::getArchAttrR600(GPUKind AK) {
More information about the llvm-commits
mailing list