[llvm] [Offload] Implement better level zero dispatch (PR #218367)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 24 03:23:06 PDT 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions h,cpp -- offload/plugins-nextgen/level_zero/dynamic_l0/L0DynWrapper.cpp offload/plugins-nextgen/level_zero/dynamic_l0/level_zero/ze_api.h offload/plugins-nextgen/level_zero/include/L0CmdListManager.h offload/plugins-nextgen/level_zero/include/L0Compat.h offload/plugins-nextgen/level_zero/include/L0Context.h offload/plugins-nextgen/level_zero/src/L0Context.cpp offload/plugins-nextgen/level_zero/src/L0Kernel.cpp offload/plugins-nextgen/level_zero/src/L0Plugin.cpp offload/plugins-nextgen/level_zero/src/L0Queue.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/offload/plugins-nextgen/level_zero/dynamic_l0/L0DynWrapper.cpp b/offload/plugins-nextgen/level_zero/dynamic_l0/L0DynWrapper.cpp
index 0908051cd..d09c93602 100644
--- a/offload/plugins-nextgen/level_zero/dynamic_l0/L0DynWrapper.cpp
+++ b/offload/plugins-nextgen/level_zero/dynamic_l0/L0DynWrapper.cpp
@@ -96,7 +96,6 @@ DLWRAP(zeCommandListAppendWaitOnEvents, 3)
DLWRAP(zeEventQueryStatus, 1)
DLWRAP(zeDriverGetDefaultContext, 1)
-
DLWRAP_FINALIZE()
#ifdef _WIN32
diff --git a/offload/plugins-nextgen/level_zero/include/L0CmdListManager.h b/offload/plugins-nextgen/level_zero/include/L0CmdListManager.h
index 70ec1726d..31c429b4b 100644
--- a/offload/plugins-nextgen/level_zero/include/L0CmdListManager.h
+++ b/offload/plugins-nextgen/level_zero/include/L0CmdListManager.h
@@ -148,7 +148,8 @@ public:
WaitEvents);
if (Result == ze_result_t::ZE_RESULT_ERROR_UNSUPPORTED_FEATURE) {
- Context.AppendLaunchKernelSupported.store(false, std::memory_order_release);
+ Context.AppendLaunchKernelSupported.store(false,
+ std::memory_order_release);
return Plugin::error(
ErrorCode::UNSUPPORTED,
"zeCommandListAppendLaunchKernelWithArguments is not "
diff --git a/offload/plugins-nextgen/level_zero/src/L0Queue.cpp b/offload/plugins-nextgen/level_zero/src/L0Queue.cpp
index 5618f2144..18d57ac2c 100644
--- a/offload/plugins-nextgen/level_zero/src/L0Queue.cpp
+++ b/offload/plugins-nextgen/level_zero/src/L0Queue.cpp
@@ -57,14 +57,17 @@ Error L0QueueTy::dispatchLaunchKernel(ze_kernel_handle_t Kernel,
bool AppendLaunchKernelWithArgsAvailable =
Device.getL0Context().LaunchKernelWithArguments.available();
-
- if (AppendLaunchKernelWithArgsAvailable && Device.getL0Context().AppendLaunchKernelSupported.load(std::memory_order_acquire)) {
+
+ if (AppendLaunchKernelWithArgsAvailable &&
+ Device.getL0Context().AppendLaunchKernelSupported.load(
+ std::memory_order_acquire)) {
auto Result = CmdList->appendLaunchKernelWithArgs(
Kernel, &KEnv.GroupCounts, &KEnv.GroupSizes, KEnv.ArgPtrs, SignalEvent,
NumWaitEvents, WaitEvents, KEnv.IsCooperative);
// Can a context have multiple users?
- if (!Device.getL0Context().AppendLaunchKernelSupported.load(std::memory_order_acquire)) {
+ if (!Device.getL0Context().AppendLaunchKernelSupported.load(
+ std::memory_order_acquire)) {
// Commandlist failed to launch kernel with arguments, fallback to older
// API.
consumeError(std::move(Result));
``````````
</details>
https://github.com/llvm/llvm-project/pull/218367
More information about the llvm-commits
mailing list