[llvm] [Object][WebAssembly] Make Wasm read failures recoverable (PR #215102)

[via llvm-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- llvm/lib/Object/WasmObjectFile.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/Object/WasmObjectFile.cpp b/llvm/lib/Object/WasmObjectFile.cpp
index 5e2248d02..52fa34019 100644
--- a/llvm/lib/Object/WasmObjectFile.cpp
+++ b/llvm/lib/Object/WasmObjectFile.cpp
@@ -1008,35 +1008,35 @@ Error WasmObjectFile::parseLinkingSectionSymtab(ReadContext &Ctx) {
                 object_error::parse_failed);
           size_t SegmentSize = DataSegments[Index].Data.Content.size();
           if (Offset > SegmentSize)
-        if ((Info.Flags & wasm::WASM_SYMBOL_BINDING_MASK) ==
-            wasm::WASM_SYMBOL_BINDING_COMMON) {
-          if (Info.Flags & wasm::WASM_SYMBOL_ABSOLUTE)
-            return make_error<GenericBinaryError>(
-                "common symbols cannot be absolute: " + Info.Name,
-                object_error::parse_failed);
-          auto Size = readVaruint64(Ctx);
-          auto Alignment = readUint8(Ctx);
-          Info.CommonRef = wasm::WasmCommonReference{Size, Alignment};
-        } else {
-          auto Index = readVaruint32(Ctx);
-          auto Offset = readVaruint64(Ctx);
-          auto Size = readVaruint64(Ctx);
-          if (!(Info.Flags & wasm::WASM_SYMBOL_ABSOLUTE)) {
-            if (Index >= DataSegments.size())
-              return make_error<GenericBinaryError>(
-                  "invalid data segment index: " + Twine(Index),
-                  object_error::parse_failed);
-            size_t SegmentSize = DataSegments[Index].Data.Content.size();
-            if (Offset > SegmentSize)
-              return make_error<GenericBinaryError>(
-                  "invalid data symbol offset: `" + Info.Name +
-                      "` (offset: " + Twine(Offset) +
-                      " segment size: " + Twine(SegmentSize) + ")",
-                  object_error::parse_failed);
-          }
-          Info.DataRef = wasm::WasmDataReference{Index, Offset, Size};
+            if ((Info.Flags & wasm::WASM_SYMBOL_BINDING_MASK) ==
+                wasm::WASM_SYMBOL_BINDING_COMMON) {
+              if (Info.Flags & wasm::WASM_SYMBOL_ABSOLUTE)
+                return make_error<GenericBinaryError>(
+                    "common symbols cannot be absolute: " + Info.Name,
+                    object_error::parse_failed);
+              auto Size = readVaruint64(Ctx);
+              auto Alignment = readUint8(Ctx);
+              Info.CommonRef = wasm::WasmCommonReference{Size, Alignment};
+            } else {
+              auto Index = readVaruint32(Ctx);
+              auto Offset = readVaruint64(Ctx);
+              auto Size = readVaruint64(Ctx);
+              if (!(Info.Flags & wasm::WASM_SYMBOL_ABSOLUTE)) {
+                if (Index >= DataSegments.size())
+                  return make_error<GenericBinaryError>(
+                      "invalid data segment index: " + Twine(Index),
+                      object_error::parse_failed);
+                size_t SegmentSize = DataSegments[Index].Data.Content.size();
+                if (Offset > SegmentSize)
+                  return make_error<GenericBinaryError>(
+                      "invalid data symbol offset: `" + Info.Name +
+                          "` (offset: " + Twine(Offset) +
+                          " segment size: " + Twine(SegmentSize) + ")",
+                      object_error::parse_failed);
+              }
+              Info.DataRef = wasm::WasmDataReference{Index, Offset, Size};
+            }
         }
-      }
       break;
 
     case wasm::WASM_SYMBOL_TYPE_SECTION: {

``````````

</details>


https://github.com/llvm/llvm-project/pull/215102