[llvm] [SPIR-V] Remove metadata-driven kernel arg Volatile decoration (PR #215790)

[LLVM Continuous Integration via llvm-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `amdgpu-clang-flang` running on `AMD-bb-w-05` while building `llvm` at step 3 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/234/builds/2780

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 3 (annotate) failure: 'python ../llvm.src/offload/ci/openmp-offload-amdgpu-clang-flang.py ...' (failure)
...
PASS: libomp :: ompt/synchronization/barrier/implicit_task_data.c (245 of 502)
PASS: libomp :: ompt/synchronization/barrier/parallel_region.c (246 of 502)
PASS: libomp :: ompt/worksharing/sections_dispatch.c (247 of 502)
PASS: libomp :: ompt/worksharing/single.c (248 of 502)
PASS: libomp :: parallel/omp_parallel_default.c (249 of 502)
PASS: libomp :: parallel/omp_parallel_firstprivate.c (250 of 502)
PASS: libomp :: ompt/worksharing/for/static.c (251 of 502)
PASS: libomp :: ompt/worksharing/for/static_serialized.c (252 of 502)
PASS: libomp :: ompt/worksharing/for/dynamic_split.c (253 of 502)
PASS: libomp :: ompt/worksharing/for/guided.c (254 of 502)
FAIL: libarcher :: races/critical-unrelated.c (255 of 502)
******************** TEST 'libarcher :: races/critical-unrelated.c' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 13
/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./bin/clang -fopenmp  -gdwarf-4 -O1 -fsanitize=thread  -I /home/botworker/bbot/amdgpu-clang-flang/llvm.src/openmp/tools/archer/tests -I /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -L /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -Wl,-rpath,/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/openmp/runtime/src   /home/botworker/bbot/amdgpu-clang-flang/llvm.src/openmp/tools/archer/tests/races/critical-unrelated.c -o /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/openmp/tools/archer/tests/races/Output/critical-unrelated.c.tmp -latomic && env TSAN_OPTIONS='ignore_noninstrumented_modules=0:ignore_noninstrumented_modules=1' /home/botworker/bbot/amdgpu-clang-flang/llvm.src/openmp/tools/archer/tests/deflake.bash /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/openmp/tools/archer/tests/races/Output/critical-unrelated.c.tmp 2>&1 | tee /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/openmp/tools/archer/tests/races/Output/critical-unrelated.c.tmp.log | /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./bin/FileCheck /home/botworker/bbot/amdgpu-clang-flang/llvm.src/openmp/tools/archer/tests/races/critical-unrelated.c
# executed command: /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./bin/clang -fopenmp -gdwarf-4 -O1 -fsanitize=thread -I /home/botworker/bbot/amdgpu-clang-flang/llvm.src/openmp/tools/archer/tests -I /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -L /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -Wl,-rpath,/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/openmp/runtime/src /home/botworker/bbot/amdgpu-clang-flang/llvm.src/openmp/tools/archer/tests/races/critical-unrelated.c -o /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/openmp/tools/archer/tests/races/Output/critical-unrelated.c.tmp -latomic
# note: command had no output on stdout or stderr
# executed command: env TSAN_OPTIONS=ignore_noninstrumented_modules=0:ignore_noninstrumented_modules=1 /home/botworker/bbot/amdgpu-clang-flang/llvm.src/openmp/tools/archer/tests/deflake.bash /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/openmp/tools/archer/tests/races/Output/critical-unrelated.c.tmp
# note: command had no output on stdout or stderr
# executed command: tee /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/openmp/tools/archer/tests/races/Output/critical-unrelated.c.tmp.log
# note: command had no output on stdout or stderr
# executed command: /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./bin/FileCheck /home/botworker/bbot/amdgpu-clang-flang/llvm.src/openmp/tools/archer/tests/races/critical-unrelated.c
# .---command stderr------------
# | /home/botworker/bbot/amdgpu-clang-flang/llvm.src/openmp/tools/archer/tests/races/critical-unrelated.c:41:11: error: CHECK: expected string not found in input
# | // CHECK: ThreadSanitizer: reported {{[1-7]}} warnings
# |           ^
# | <stdin>:23:5: note: scanning from here
# | DONE
# |     ^
# | <stdin>:24:1: note: possible intended match here
# | ThreadSanitizer: thread T4 finished with ignores enabled, created at:
# | ^
# | 
# | Input file: <stdin>
# | Check file: /home/botworker/bbot/amdgpu-clang-flang/llvm.src/openmp/tools/archer/tests/races/critical-unrelated.c
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# |             .
# |             .
# |             .
# |            18:  #0 pthread_create /home/botworker/bbot/amdgpu-clang-flang/llvm.src/compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp:1082:3 (critical-unrelated.c.tmp+0xa501a) 
# |            19:  #1 __kmp_create_worker <null> (libomp.so+0xcdd92) 
# |            20:  
Step 8 (test-openmp) failure: test-openmp (failure)
...
PASS: libomp :: ompt/synchronization/barrier/implicit_task_data.c (245 of 502)
PASS: libomp :: ompt/synchronization/barrier/parallel_region.c (246 of 502)
PASS: libomp :: ompt/worksharing/sections_dispatch.c (247 of 502)
PASS: libomp :: ompt/worksharing/single.c (248 of 502)
PASS: libomp :: parallel/omp_parallel_default.c (249 of 502)
PASS: libomp :: parallel/omp_parallel_firstprivate.c (250 of 502)
PASS: libomp :: ompt/worksharing/for/static.c (251 of 502)
PASS: libomp :: ompt/worksharing/for/static_serialized.c (252 of 502)
PASS: libomp :: ompt/worksharing/for/dynamic_split.c (253 of 502)
PASS: libomp :: ompt/worksharing/for/guided.c (254 of 502)
FAIL: libarcher :: races/critical-unrelated.c (255 of 502)
******************** TEST 'libarcher :: races/critical-unrelated.c' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 13
/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./bin/clang -fopenmp  -gdwarf-4 -O1 -fsanitize=thread  -I /home/botworker/bbot/amdgpu-clang-flang/llvm.src/openmp/tools/archer/tests -I /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -L /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -Wl,-rpath,/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/openmp/runtime/src   /home/botworker/bbot/amdgpu-clang-flang/llvm.src/openmp/tools/archer/tests/races/critical-unrelated.c -o /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/openmp/tools/archer/tests/races/Output/critical-unrelated.c.tmp -latomic && env TSAN_OPTIONS='ignore_noninstrumented_modules=0:ignore_noninstrumented_modules=1' /home/botworker/bbot/amdgpu-clang-flang/llvm.src/openmp/tools/archer/tests/deflake.bash /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/openmp/tools/archer/tests/races/Output/critical-unrelated.c.tmp 2>&1 | tee /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/openmp/tools/archer/tests/races/Output/critical-unrelated.c.tmp.log | /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./bin/FileCheck /home/botworker/bbot/amdgpu-clang-flang/llvm.src/openmp/tools/archer/tests/races/critical-unrelated.c
# executed command: /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./bin/clang -fopenmp -gdwarf-4 -O1 -fsanitize=thread -I /home/botworker/bbot/amdgpu-clang-flang/llvm.src/openmp/tools/archer/tests -I /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -L /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -Wl,-rpath,/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/openmp/runtime/src /home/botworker/bbot/amdgpu-clang-flang/llvm.src/openmp/tools/archer/tests/races/critical-unrelated.c -o /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/openmp/tools/archer/tests/races/Output/critical-unrelated.c.tmp -latomic
# note: command had no output on stdout or stderr
# executed command: env TSAN_OPTIONS=ignore_noninstrumented_modules=0:ignore_noninstrumented_modules=1 /home/botworker/bbot/amdgpu-clang-flang/llvm.src/openmp/tools/archer/tests/deflake.bash /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/openmp/tools/archer/tests/races/Output/critical-unrelated.c.tmp
# note: command had no output on stdout or stderr
# executed command: tee /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/openmp/tools/archer/tests/races/Output/critical-unrelated.c.tmp.log
# note: command had no output on stdout or stderr
# executed command: /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./bin/FileCheck /home/botworker/bbot/amdgpu-clang-flang/llvm.src/openmp/tools/archer/tests/races/critical-unrelated.c
# .---command stderr------------
# | /home/botworker/bbot/amdgpu-clang-flang/llvm.src/openmp/tools/archer/tests/races/critical-unrelated.c:41:11: error: CHECK: expected string not found in input
# | // CHECK: ThreadSanitizer: reported {{[1-7]}} warnings
# |           ^
# | <stdin>:23:5: note: scanning from here
# | DONE
# |     ^
# | <stdin>:24:1: note: possible intended match here
# | ThreadSanitizer: thread T4 finished with ignores enabled, created at:
# | ^
# | 
# | Input file: <stdin>
# | Check file: /home/botworker/bbot/amdgpu-clang-flang/llvm.src/openmp/tools/archer/tests/races/critical-unrelated.c
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# |             .
# |             .
# |             .
# |            18:  #0 pthread_create /home/botworker/bbot/amdgpu-clang-flang/llvm.src/compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp:1082:3 (critical-unrelated.c.tmp+0xa501a) 
# |            19:  #1 __kmp_create_worker <null> (libomp.so+0xcdd92) 
# |            20:  

```

</details>

https://github.com/llvm/llvm-project/pull/215790