[llvm] cc61111 - [CodeGen] Give NewPM SplitCriticalEdge default values

[via llvm-commits]

Author: Aiden Grossman
Date: 2026-08-20T06:14:25-07:00
New Revision: cc611118ba672083ae9613514abc8594a3e027ff

URL: https://github.com/llvm/llvm-project/commit/cc611118ba672083ae9613514abc8594a3e027ff
DIFF: https://github.com/llvm/llvm-project/commit/cc611118ba672083ae9613514abc8594a3e027ff.diff

LOG: [CodeGen] Give NewPM SplitCriticalEdge default values

To match the legacyPM version. This is needed for migrating
RegBankSelect without explicitly passing nullptr to these parameters,
which is not ideal given the LegacyPM version already sets them to
defaults.

Reviewers: arsenm, nikic

Pull Request: https://github.com/llvm/llvm-project/pull/217504

Added: 
    

Modified: 
    llvm/include/llvm/CodeGen/MachineBasicBlock.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/CodeGen/MachineBasicBlock.h b/llvm/include/llvm/CodeGen/MachineBasicBlock.h
index 47430a100b3cc..d5c31c4b7281b 100644
--- a/llvm/include/llvm/CodeGen/MachineBasicBlock.h
+++ b/llvm/include/llvm/CodeGen/MachineBasicBlock.h
@@ -1030,13 +1030,17 @@ class MachineBasicBlock
   }
 
   // Helper method for new pass manager migration.
-  LLVM_ABI MachineBasicBlock *SplitCriticalEdge(
-      MachineBasicBlock *Succ, const SplitCriticalEdgeAnalyses &Analyses,
-      std::vector<SparseBitVector<>> *LiveInSets, MachineDomTreeUpdater *MDTU);
+  LLVM_ABI MachineBasicBlock *
+  SplitCriticalEdge(MachineBasicBlock *Succ,
+                    const SplitCriticalEdgeAnalyses &Analyses,
+                    std::vector<SparseBitVector<>> *LiveInSets = nullptr,
+                    MachineDomTreeUpdater *MDTU = nullptr);
 
-  LLVM_ABI MachineBasicBlock *SplitCriticalEdge(
-      MachineBasicBlock *Succ, Pass *P, MachineFunctionAnalysisManager *MFAM,
-      std::vector<SparseBitVector<>> *LiveInSets, MachineDomTreeUpdater *MDTU);
+  LLVM_ABI MachineBasicBlock *
+  SplitCriticalEdge(MachineBasicBlock *Succ, Pass *P,
+                    MachineFunctionAnalysisManager *MFAM,
+                    std::vector<SparseBitVector<>> *LiveInSets = nullptr,
+                    MachineDomTreeUpdater *MDTU = nullptr);
 
   /// Check if the edge between this block and the given successor \p
   /// Succ, can be split. If this returns true a subsequent call to