[llvm] [llvm-readobj][ELF] Remove flush from `GNUELFDumper::printField()` (PR #217602)

via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 20 05:25:09 PDT 2026


llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-llvm-binary-utilities

Author: Andrew Ng (nga888)

<details>
<summary>Changes</summary>

This dramatically improves the performance of the dumping of ELF symbols. For `llvm-readelf -s UE5Demo.elf > symbols.txt`, example time deltas are:

  Windows: ~32s -> ~1s
  Linux:   ~10s -> ~1s

---
Full diff: https://github.com/llvm/llvm-project/pull/217602.diff


1 Files Affected:

- (modified) llvm/tools/llvm-readobj/ELFDumper.cpp (-1) 


``````````diff
diff --git a/llvm/tools/llvm-readobj/ELFDumper.cpp b/llvm/tools/llvm-readobj/ELFDumper.cpp
index 8b21b25068ff8..ab81de626e1d3 100644
--- a/llvm/tools/llvm-readobj/ELFDumper.cpp
+++ b/llvm/tools/llvm-readobj/ELFDumper.cpp
@@ -701,7 +701,6 @@ template <typename ELFT> class GNUELFDumper : public ELFDumper<ELFT> {
     if (F.Column != 0)
       OS.PadToColumn(F.Column);
     OS << F.Str;
-    OS.flush();
     return OS;
   }
   void printHashedSymbol(const Elf_Sym *Sym, unsigned SymIndex,

``````````

</details>


https://github.com/llvm/llvm-project/pull/217602


More information about the llvm-commits mailing list