[llvm] 892eb7b - [AMDGPU] Inline mayIgnoreSignedZero into raw flag check (NFC) (#217580)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 20 05:23:51 PDT 2026
Author: Arseniy Obolenskiy
Date: 2026-08-20T14:23:47+02:00
New Revision: 892eb7b5121e6153f41dff86d9ba8e154b9aeec3
URL: https://github.com/llvm/llvm-project/commit/892eb7b5121e6153f41dff86d9ba8e154b9aeec3
DIFF: https://github.com/llvm/llvm-project/commit/892eb7b5121e6153f41dff86d9ba8e154b9aeec3.diff
LOG: [AMDGPU] Inline mayIgnoreSignedZero into raw flag check (NFC) (#217580)
Precommit for https://github.com/llvm/llvm-project/pull/217573
Added:
Modified:
llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
llvm/lib/Target/AMDGPU/AMDGPUISelLowering.h
Removed:
################################################################################
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp b/llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
index 3f93ca66dca17..7acc9ca2bafbd 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
@@ -648,14 +648,6 @@ AMDGPUTargetLowering::AMDGPUTargetLowering(const TargetMachine &TM,
setMaxLargeFPConvertBitWidthSupported(64);
}
-bool AMDGPUTargetLowering::mayIgnoreSignedZero(SDValue Op) const {
- const auto Flags = Op.getNode()->getFlags();
- if (Flags.hasNoSignedZeros())
- return true;
-
- return false;
-}
-
//===----------------------------------------------------------------------===//
// Target Information
//===----------------------------------------------------------------------===//
@@ -5230,7 +5222,7 @@ SDValue AMDGPUTargetLowering::performFNegCombine(SDNode *N,
SDLoc SL(N);
switch (Opc) {
case ISD::FADD: {
- if (!mayIgnoreSignedZero(N0) && !N->getFlags().hasNoSignedZeros())
+ if (!N0->getFlags().hasNoSignedZeros() && !N->getFlags().hasNoSignedZeros())
return SDValue();
// (fneg (fadd x, y)) -> (fadd (fneg x), (fneg y))
@@ -5278,7 +5270,7 @@ SDValue AMDGPUTargetLowering::performFNegCombine(SDNode *N,
case ISD::FMA:
case ISD::FMAD: {
// TODO: handle llvm.amdgcn.fma.legacy
- if (!mayIgnoreSignedZero(N0) && !N->getFlags().hasNoSignedZeros())
+ if (!N0->getFlags().hasNoSignedZeros() && !N->getFlags().hasNoSignedZeros())
return SDValue();
// (fneg (fma x, y, z)) -> (fma x, (fneg y), (fneg z))
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUISelLowering.h b/llvm/lib/Target/AMDGPU/AMDGPUISelLowering.h
index f24f33e7dcb70..912315532b7d5 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUISelLowering.h
+++ b/llvm/lib/Target/AMDGPU/AMDGPUISelLowering.h
@@ -194,8 +194,6 @@ class AMDGPUTargetLowering : public TargetLowering {
AMDGPUTargetLowering(const TargetMachine &TM, const TargetSubtargetInfo &STI,
const AMDGPUSubtarget &AMDGPUSTI);
- bool mayIgnoreSignedZero(SDValue Op) const;
-
static inline SDValue stripBitcast(SDValue Val) {
return Val.getOpcode() == ISD::BITCAST ? Val.getOperand(0) : Val;
}
More information about the llvm-commits
mailing list