[llvm] [AMDGPU] Fix combine-binop-s64-with-s32-mask.mir input to use i32 instead of s32 (NFC) (PR #217410)
Arseniy Obolenskiy via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 20 04:21:41 PDT 2026
aobolensk wrote:
> The problem in combine-binop-s64-with-s32-mask.mir is mixing s32 and i32, and not notifying CSE that instruction was changed (iirc replaceRegWith changed instruction, by changing type on some reg, that was already mapped in CSE).
>
> You are trying to change how replaceRegWith which has much larger impact then it looks like here. If you want to chase that need to prepare a couple mir tests to see the impact and effect on replaceRegWith.
>
> If you want to fix combine-binop-s64-with-s32-mask.mir, use don't use LLT::scalar in input, that is what input should look like if it came from print-after-something on amdgpu.
Thanks for the explanation! I have reverted codegen change, limited only to AMDGPU test change
https://github.com/llvm/llvm-project/pull/217410
More information about the llvm-commits
mailing list