[llvm] [SCEV] Look up uniqued nodes by using interned profile. (NFC) (PR #217571)

Florian Hahn via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 20 03:33:57 PDT 2026


https://github.com/fhahn commented:

> Are you sure that it's the comparison that is beneficial here and that the benefits not just come from inlining? stage2 is built with ThinLTO, which I'd expect inlines the function and is able to resolve the indirect function call, would explain why there's no benefit there.


Hmm yes that would make sense; I wasn't aware that stage2 uses ThinLTO.

> 
> (So maybe we should just inline that function without an extra overload, solely for the benefit of stage1 builds?)

Let me check; it may be worth even if it does not help production builds of Clang, as most people probably do not use (Thin)LTO at desk or in CI

https://github.com/llvm/llvm-project/pull/217571


More information about the llvm-commits mailing list